Bug 199286 - Fix build error on WebCore when disabling ENABLE_INDEXED_DATABASE.
Summary: Fix build error on WebCore when disabling ENABLE_INDEXED_DATABASE.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-27 14:17 PDT by Basuke Suzuki
Modified: 2019-06-27 18:53 PDT (History)
3 users (show)

See Also:

Attachments
PATCH (1.58 KB, patch)
2019-06-27 14:24 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
ONE MORE TIME (1.58 KB, patch)
2019-06-27 16:23 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2019-06-27 17:25 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2019-06-27 14:17:20 PDT 
../Source/WebCore/testing/Internals.cpp:2405:12: error: use of undeclared identifier 'IDBTransaction'
    return IDBTransaction::numberOfIDBTransactions;
Comment 1 Basuke Suzuki 2019-06-27 14:24:33 PDT 
Created attachment 373053 [details]
PATCH
Comment 2 Basuke Suzuki 2019-06-27 16:23:46 PDT 
Created attachment 373067 [details]
ONE MORE TIME
Comment 3 Brent Fulgham 2019-06-27 16:33:35 PDT 
Comment on attachment 373067 [details]
ONE MORE TIME

View in context: https://bugs.webkit.org/attachment.cgi?id=373067&action=review

> Source/WebCore/testing/Internals.cpp:2406
> +#if ENABLE(INDEXED_DATABASE)

I think that if you have this disabled, you need to also disable it in the header, don't you?
Comment 4 Basuke Suzuki 2019-06-27 17:08:22 PDT 
Comment on attachment 373067 [details]
ONE MORE TIME

View in context: https://bugs.webkit.org/attachment.cgi?id=373067&action=review

>> Source/WebCore/testing/Internals.cpp:2406
>> +#if ENABLE(INDEXED_DATABASE)
> 
> I think that if you have this disabled, you need to also disable it in the header, don't you?

Ah, right. I should do that. Also in idl.
Comment 5 Basuke Suzuki 2019-06-27 17:25:53 PDT 
Created attachment 373070 [details]
Patch
Comment 6 Basuke Suzuki 2019-06-27 18:17:53 PDT 
It passed! Thanks, Brent.
Comment 7 WebKit Commit Bot 2019-06-27 18:49:35 PDT 
Comment on attachment 373070 [details]
Patch

Clearing flags on attachment: 373070

Committed r246917: <https://trac.webkit.org/changeset/246917>
Comment 8 WebKit Commit Bot 2019-06-27 18:49:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-06-27 18:53:48 PDT 
<rdar://problem/52300694>