Bug 199279 - Move WebKitLegacy off of a couple AppKit ivars
Summary: Move WebKitLegacy off of a couple AppKit ivars
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks: 199209
  Show dependency tree / graph
 
Reported: 2019-06-27 11:20 PDT by Timothy Hatcher
Modified: 2019-07-11 10:56 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.61 KB, patch)
2019-06-27 12:03 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2019-06-27 11:20:37 PDT 
We use _borderView on NSWindow and _subviews on NSView. There are alternatives now.

<rdar://problem/34983438>
Comment 1 Timothy Hatcher 2019-06-27 12:03:41 PDT 
Created attachment 373042 [details]
Patch
Comment 2 WebKit Commit Bot 2019-06-27 14:11:19 PDT 
Comment on attachment 373042 [details]
Patch

Clearing flags on attachment: 373042

Committed r246905: <https://trac.webkit.org/changeset/246905>
Comment 3 WebKit Commit Bot 2019-06-27 14:11:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Frédéric Wang (:fredw) 2019-07-11 03:41:29 PDT 
Comment on attachment 373042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373042&action=review

> Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237
> +    ALLOW_DEPRECATED_DECLARATIONS_END

@Timothy: These _subviews are causing macOS build failures with XCode 11.0 beta 3 and the public SDK (that seems to be the only build failure though). Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe because I'm using Mojave not Catalina?).
Comment 5 Timothy Hatcher 2019-07-11 10:56:11 PDT 
(In reply to Frédéric Wang (:fredw) from comment #4)
> Comment on attachment 373042 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373042&action=review
> 
> > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237
> > +    ALLOW_DEPRECATED_DECLARATIONS_END
> 
> @Timothy: These _subviews are causing macOS build failures with XCode 11.0
> beta 3 and the public SDK (that seems to be the only build failure though).
> Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe
> because I'm using Mojave not Catalina?).

The SPI is only on Catalina. But it sounds like the SDK removed the ivars still…