Bug 199279 – Move WebKitLegacy off of a couple AppKit ivars

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Timothy Hatcher]

We use _borderView on NSWindow and _subviews on NSView. There are alternatives now.

<rdar://problem/34983438>

[Timothy Hatcher]

Created attachment 373042 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 373042 [details]
Patch

Clearing flags on attachment: 373042

Committed r246905: <https://trac.webkit.org/changeset/246905>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Frédéric Wang (:fredw)]

Comment on attachment 373042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373042&action=review

> Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237
> +    ALLOW_DEPRECATED_DECLARATIONS_END

@Timothy: These _subviews are causing macOS build failures with XCode 11.0 beta 3 and the public SDK (that seems to be the only build failure though). Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe because I'm using Mojave not Catalina?).

[Timothy Hatcher]

(In reply to Frédéric Wang (:fredw) from comment #4)
> Comment on attachment 373042 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373042&action=review
> 
> > Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:237
> > +    ALLOW_DEPRECATED_DECLARATIONS_END
> 
> @Timothy: These _subviews are causing macOS build failures with XCode 11.0
> beta 3 and the public SDK (that seems to be the only build failure though).
> Any idea? I wonder why SUBVIEWS_IVAR_SPI is not set with Xcode beta (maybe
> because I'm using Mojave not Catalina?).

The SPI is only on Catalina. But it sounds like the SDK removed the ivars still…