Bug 199277 - Protect StorageManager::LocalStorageNamespace::m_storageAreaMap with a mutex
Summary: Protect StorageManager::LocalStorageNamespace::m_storageAreaMap with a mutex
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-27 10:49 PDT by Alex Christensen
Modified: 2019-06-27 13:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.10 KB, patch)
2019-06-27 10:52 PDT, Alex Christensen 		ggaren: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-06-27 10:49:17 PDT 
Protect StorageManager::LocalStorageNamespace::m_storageAreaMap with a mutex
Comment 1 Alex Christensen 2019-06-27 10:52:00 PDT 
Created attachment 373036 [details]
Patch
Comment 2 Alex Christensen 2019-06-27 10:52:02 PDT 
<rdar://problem/52098995>
Comment 3 Sihui Liu 2019-06-27 11:23:27 PDT 
https://bugs.webkit.org/show_bug.cgi?id=199278 may solve this?
Comment 4 Geoffrey Garen 2019-06-27 11:37:11 PDT 
Given that bug 199278 removes didDestroyStorageArea, I think this patch is obsolete. (Also, given the hang mentioned in bug 199278, this patch would probably cause more hangs.)
Comment 5 Alex Christensen 2019-06-27 13:12:39 PDT 
Agreed.  That patch is what we should do instead