Bug 199270 - Use JSC_GLIB_API_ENABLED instead of USE(GLIB) as a compile-time check for GLib JSC API
Summary: Use JSC_GLIB_API_ENABLED instead of USE(GLIB) as a compile-time check for GLi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-27 06:18 PDT by Konstantin Tokarev
Modified: 2019-06-27 08:48 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.34 KB, patch)
2019-06-27 06:22 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2019-06-27 06:18:20 PDT 
This change allows building code with enabled USE(GLIB) but without GLib JSC API
Comment 1 Konstantin Tokarev 2019-06-27 06:22:15 PDT 
Created attachment 373025 [details]
Patch
Comment 2 Michael Catanzaro 2019-06-27 07:21:23 PDT 
Comment on attachment 373025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373025&action=review

> Source/JavaScriptCore/heap/Heap.cpp:99
> -#if USE(GLIB)
> +#ifdef JSC_GLIB_API_ENABLED

How about #if ENABLE(JSC_GLIB_API)?
Comment 3 Konstantin Tokarev 2019-06-27 07:27:11 PDT 
This macro is also used in public headers of JSC where ENABLE() is unavailable. It's possible to introduce another macro ENABLE_JSC_GLIB_API to be used inside implementation code, but I've decided not to multiply entities
Comment 4 Michael Catanzaro 2019-06-27 08:00:03 PDT 
Comment on attachment 373025 [details]
Patch

OK then. I also missed that it already exists. But why no r?
Comment 5 Konstantin Tokarev 2019-06-27 08:11:18 PDT 
Comment on attachment 373025 [details]
Patch

Oops, I wanted to check EWS status
Comment 6 EWS Watchlist 2019-06-27 08:24:05 PDT 
Comment on attachment 373025 [details]
Patch

Attachment 373025 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/12592494

New failing tests:
mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases
apiTests
Comment 7 Konstantin Tokarev 2019-06-27 08:39:00 PDT 
Comment on attachment 373025 [details]
Patch

Clearing flags on attachment: 373025

Committed r246881: <https://trac.webkit.org/changeset/246881>
Comment 8 Konstantin Tokarev 2019-06-27 08:39:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-06-27 08:48:20 PDT 
<rdar://problem/52261875>