Bug 199264 – [JSC] LLInt CLoop can't compile for Windows x64 due to Opcode size

• Status: NEW
• Component: JavaScriptCore

[Fujii Hironori]

I get the following compilation error by compiling LLInt CLoop for WinCairo 64bit builds.

>------ Build started: Project: JavaScriptCore (JavaScriptCore\JavaScriptCore), Configuration: Debug x64 ------
>LowLevelInterpreter.cpp
>C:\webkit\gc\WebKitBuild\Debug\WTF\Headers\wtf/StdLibExtras.h(136,36): error C2338:  bitwise_cast size of FromType and ToType must be equal!
>C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message :  see reference to function template instantiation 'ToType WTF::bitwise_cast<JSC::Opcode,uintptr_t>(FromType)' being compiled
>C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message :         with
>C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message :         [
>C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message :             ToType=JSC::Opcode,
>C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message :             FromType=uintptr_t
>C:\webkit\gc\Source\JavaScriptCore\llint\LowLevelInterpreter.cpp(158): message :         ]
>Done building project "JavaScriptCore.vcxproj" -- FAILED.

[Fujii Hironori]

Created attachment 373015 [details]
Patch

[EWS Watchlist]

Attachment 373015 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/Opcode.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/parser/Nodes.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Fujii Hironori]

Created attachment 375281 [details]
WIP patch

[Fujii Hironori]

Created attachment 375283 [details]
WIP patch

[Fujii Hironori]

Created attachment 435843 [details]
WIP patch