Bug 199257 - [iOS] Support select all in non-editable element
Summary: [iOS] Support select all in non-editable element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 190571
  Show dependency treegraph
 
Reported: 2019-06-26 20:06 PDT by Daniel Bates
Modified: 2019-07-08 16:08 PDT (History)
4 users (show)

See Also:


Attachments
For the bots (761 bytes, patch)
2019-07-02 16:04 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (5.04 KB, patch)
2019-07-02 16:36 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (5.84 KB, patch)
2019-07-02 20:50 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (9.47 KB, patch)
2019-07-03 16:16 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (9.56 KB, patch)
2019-07-03 16:20 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-06-26 20:06:57 PDT
We should support select all (Command + a) in non-editable elements on iOS just like we do on Mac.
Comment 1 Daniel Bates 2019-07-02 16:04:20 PDT
Created attachment 373368 [details]
For the bots
Comment 2 Radar WebKit Bug Importer 2019-07-02 16:11:16 PDT
<rdar://problem/52553667>
Comment 3 Daniel Bates 2019-07-02 16:36:18 PDT
Created attachment 373370 [details]
Patch

I need to check if this is okay to do in iOS 12. At least iBooks on iOS 12 allows select all of non-editable content...need to confirm if this was platform convention and WebKit was being too restrictive. Otherwise, will need to keep existing select all condition for iOS 12 and compile-time switch to return YES otherwise. Thoughts?
Comment 4 Daniel Bates 2019-07-02 18:17:25 PDT
(In reply to Daniel Bates from comment #3)
> Created attachment 373370 [details]
> Patch
> 
> I need to check if this is okay to do in iOS 12. At least iBooks on iOS 12
> allows select all of non-editable content...need to confirm if this was
> platform convention and WebKit was being too restrictive. Otherwise, will
> need to keep existing select all condition for iOS 12 and compile-time
> switch to return YES otherwise. Thoughts?

Need compile time switch. Reviewers shouldn't get scared off because of this
Comment 5 Daniel Bates 2019-07-02 20:50:02 PDT
Created attachment 373380 [details]
Patch
Comment 6 Daniel Bates 2019-07-03 16:16:46 PDT
Created attachment 373428 [details]
Patch
Comment 7 Daniel Bates 2019-07-03 16:20:13 PDT
Created attachment 373429 [details]
Patch
Comment 8 Daniel Bates 2019-07-08 16:08:23 PDT
Comment on attachment 373429 [details]
Patch

Clearing flags on attachment: 373429

Committed r247233: <https://trac.webkit.org/changeset/247233>
Comment 9 Daniel Bates 2019-07-08 16:08:25 PDT
All reviewed patches have been landed.  Closing bug.