199247 – Adopt simple structured bindings in more places

RESOLVED FIXED Bug 199247

Adopt simple structured bindings in more places

https://bugs.webkit.org/show_bug.cgi?id=199247

Summary Adopt simple structured bindings in more places

Sam Weinig

Reported 2019-06-26 16:58:40 PDT

Adopt simple structured bindings in more places

Attachments
Patch (61.43 KB, patch) 2019-06-26 18:38 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (61.43 KB, patch) 2019-06-26 19:02 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (61.44 KB, patch) 2019-06-26 19:55 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (61.52 KB, patch) 2019-06-27 06:34 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (61.52 KB, patch) 2019-06-27 09:12 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (61.53 KB, patch) 2019-06-30 19:26 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (60.35 KB, patch) 2019-06-30 20:20 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (59.40 KB, patch) 2019-07-02 08:57 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (59.13 KB, patch) 2019-07-02 10:38 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2019-06-26 18:38:29 PDT Comment hidden (obsolete)

Created attachment 372988 [details] Patch

EWS Watchlist

Comment 2 2019-06-26 18:41:27 PDT Comment hidden (obsolete)

Attachment 372988 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1179: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:370: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:380: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 24 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2019-06-26 19:02:28 PDT Comment hidden (obsolete)

Created attachment 372992 [details] Patch

EWS Watchlist

Comment 4 2019-06-26 19:04:52 PDT Comment hidden (obsolete)

Attachment 372992 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1179: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:370: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:380: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 24 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 5 2019-06-26 19:55:50 PDT Comment hidden (obsolete)

Created attachment 372996 [details] Patch

EWS Watchlist

Comment 6 2019-06-26 19:57:23 PDT Comment hidden (obsolete)

Attachment 372996 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1179: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 22 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 7 2019-06-27 06:34:59 PDT Comment hidden (obsolete)

Created attachment 373027 [details] Patch

EWS Watchlist

Comment 8 2019-06-27 06:37:33 PDT Comment hidden (obsolete)

Attachment 373027 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1182: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 22 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 9 2019-06-27 09:12:41 PDT Comment hidden (obsolete)

Created attachment 373033 [details] Patch

EWS Watchlist

Comment 10 2019-06-27 09:14:26 PDT Comment hidden (obsolete)

Attachment 373033 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1182: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 22 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 11 2019-06-30 19:26:25 PDT Comment hidden (obsolete)

Created attachment 373200 [details] Patch

EWS Watchlist

Comment 12 2019-06-30 19:28:55 PDT Comment hidden (obsolete)

Attachment 373200 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1200: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 22 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 13 2019-06-30 20:20:15 PDT Comment hidden (obsolete)

Created attachment 373206 [details] Patch

EWS Watchlist

Comment 14 2019-06-30 20:21:45 PDT Comment hidden (obsolete)

Attachment 373206 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1200: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 22 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 15 2019-07-02 08:57:02 PDT Comment hidden (obsolete)

Created attachment 373327 [details] Patch

EWS Watchlist

Comment 16 2019-07-02 08:58:49 PDT Comment hidden (obsolete)

Attachment 373327 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1202: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 22 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 17 2019-07-02 10:38:57 PDT

Created attachment 373338 [details] Patch

EWS Watchlist

Comment 18 2019-07-02 10:41:26 PDT Comment hidden (obsolete)

Attachment 373338 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/InlineTextBox.cpp:183: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/InlineTextBox.cpp:439: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp:293: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/runtime/PromiseDeferredTimer.cpp:57: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:86: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/WidthIterator.cpp:279: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/css/StyleResolver.cpp:1202: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1311: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1411: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1547: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandleImpl.cpp:85: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:430: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:454: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:205: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:113: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:583: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/PathUtilities.cpp:586: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/svg/animation/SVGSMILElement.cpp:222: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:101: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/platform/graphics/ComplexTextController.cpp:791: Extra space before [. [whitespace/brackets] [5] ERROR: Source/WebCore/style/StyleResolveForDocument.cpp:120: Extra space before [. [whitespace/brackets] [5] ERROR: Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp:80: Extra space before [. [whitespace/brackets] [5] Total errors found: 22 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 19 2019-07-03 13:46:47 PDT

Comment on attachment 373338 [details] Patch Clearing flags on attachment: 373338 Committed r247102: <https://trac.webkit.org/changeset/247102>

WebKit Commit Bot

Comment 20 2019-07-03 13:46:49 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 21 2019-07-03 13:47:16 PDT

<rdar://problem/52608473>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Sam Weinig

Reported

2019-06-26 16:58 PDT

Modified

2019-07-03 13:47 PDT History

CC List

4 users Show

URL

Keywords InRadar

Depends on

Blocks