RESOLVED FIXED199246
Expose UIAction identifiers for _WKElementActions 
https://bugs.webkit.org/show_bug.cgi?id=199246
Summary Expose UIAction identifiers for _WKElementActions
Dean Jackson
Reported 2019-06-26 16:48:44 PDT
Expose UIAction identifiers for _WKElementActions
Attachments
Patch (19.37 KB, patch)
2019-06-26 17:08 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
Patch (19.36 KB, patch)
2019-06-26 17:42 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-26 16:49:08 PDT
<rdar://problem/52218950>
Dean Jackson
Comment 2 2019-06-26 17:08:11 PDT
Created attachment 372971 [details] Patch
Tim Horton
Comment 3 2019-06-26 17:31:36 PDT
Comment on attachment 372971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372971&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:65 > -+ (UIImage *)imageForElementActionType:(_WKElementActionType)actionType WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); > ++ (UIImage *)imageForElementActionType:(_WKElementActionType)actionType WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(13.0)); Why this change? > Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:217 > +#if !defined(TARGET_OS_IOS) || TARGET_OS_IOS Why not a PLATFORM macro? This is an implementation file.
Dean Jackson
Comment 4 2019-06-26 17:42:35 PDT
Created attachment 372976 [details] Patch
Dean Jackson
Comment 5 2019-06-26 17:52:18 PDT
Comment on attachment 372971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372971&action=review >> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:65 >> ++ (UIImage *)imageForElementActionType:(_WKElementActionType)actionType WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(13.0)); > > Why this change? Because we have announced that the next version of iOS will be called 13? >> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:217 >> +#if !defined(TARGET_OS_IOS) || TARGET_OS_IOS > > Why not a PLATFORM macro? This is an implementation file. Yes, thanks. Will fix.
Dean Jackson
Comment 6 2019-06-26 18:11:39 PDT
Committed r246865: <https://trac.webkit.org/changeset/246865>
Darin Adler
Comment 7 2019-06-26 18:34:18 PDT
I still see TARGET_OS_IOS in the .mm file.
Dean Jackson
Comment 8 2019-06-26 18:44:42 PDT
(In reply to Darin Adler from comment #7) > I still see TARGET_OS_IOS in the .mm file. That was fixed, along with other things in https://bugs.webkit.org/show_bug.cgi?id=199255 which was r246867
Darin Adler
Comment 9 2019-06-26 18:49:10 PDT
Ah, great, how did I miss that? I actually looked at that check-in first!
Note You need to log in before you can comment on or make changes to this bug.