Bug 199245 - Upstream use of MACCATALYST
Summary: Upstream use of MACCATALYST
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-26 16:46 PDT by Beth Dakin
Modified: 2019-06-27 11:17 PDT (History)
8 users (show)

See Also:


Attachments
Patch (145.22 KB, patch)
2019-06-26 16:55 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (144.87 KB, patch)
2019-06-26 17:24 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.48 MB, application/zip)
2019-06-26 22:38 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2019-06-26 16:46:52 PDT
Upstream use of MACCATALYST

rdar://problem/51687723
Comment 1 Beth Dakin 2019-06-26 16:55:08 PDT
Created attachment 372968 [details]
Patch
Comment 2 Build Bot 2019-06-26 16:57:59 PDT
Attachment 372968 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:28:  Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file.  [build/version_check] [5]
Total errors found: 10 in 108 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2019-06-26 17:24:45 PDT
Created attachment 372973 [details]
Patch
Comment 4 Tim Horton 2019-06-26 17:28:52 PDT
Comment on attachment 372973 [details]
Patch

rs=me
Comment 5 Build Bot 2019-06-26 22:38:28 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2019-06-26 22:38:30 PDT Comment hidden (obsolete)
Comment 7 Timothy Hatcher 2019-06-27 10:45:10 PDT
Comment on attachment 372973 [details]
Patch

Unrelated test failure.
Comment 8 WebKit Commit Bot 2019-06-27 11:17:42 PDT
Comment on attachment 372973 [details]
Patch

Clearing flags on attachment: 372973

Committed r246892: <https://trac.webkit.org/changeset/246892>
Comment 9 WebKit Commit Bot 2019-06-27 11:17:44 PDT
All reviewed patches have been landed.  Closing bug.