RESOLVED FIXED 199241
Remove all selection view animations before dumping results 
https://bugs.webkit.org/show_bug.cgi?id=199241
Summary Remove all selection view animations before dumping results
Daniel Bates
Reported 2019-06-26 16:10:52 PDT
Let's try an idea Wenson mentioned to reduce selection test flakiness on iOS.
Attachments
Patch (1.65 KB, patch)
2019-06-26 16:16 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.89 MB, application/zip)
2019-06-26 18:10 PDT, EWS Watchlist 		no flags
Details
Patch (1.88 KB, patch)
2019-08-22 15:44 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2019-08-22 15:45 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-06-26 16:16:26 PDT
Created attachment 372963 [details] Patch
Daniel Bates
Comment 2 2019-06-26 16:52:40 PDT
Oops
EWS Watchlist
Comment 3 2019-06-26 18:10:43 PDT
Comment on attachment 372963 [details] Patch Attachment 372963 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12585766 New failing tests: webanimations/accelerated-transition-by-removing-property.html
EWS Watchlist
Comment 4 2019-06-26 18:10:44 PDT
Created attachment 372983 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Wenson Hsieh
Comment 5 2019-06-27 09:49:38 PDT
Comment on attachment 372963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372963&action=review > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:85 > + [[mainWebView()->platformView() scrollView] _removeAllAnimations:YES]; As Tim and I mentioned, this should just be on the selection view...
Daniel Bates
Comment 6 2019-06-27 10:14:33 PDT
(In reply to Wenson Hsieh from comment #5) > Comment on attachment 372963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372963&action=review > > > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:85 > > + [[mainWebView()->platformView() scrollView] _removeAllAnimations:YES]; > > As Tim and I mentioned, this should just be on the selection view... That's what the Oops was 😀
Daniel Bates
Comment 7 2019-08-22 15:44:36 PDT
Created attachment 377062 [details] Patch
Daniel Bates
Comment 8 2019-08-22 15:45:43 PDT
Created attachment 377063 [details] Patch
Daniel Bates
Comment 9 2019-09-09 11:56:54 PDT
Comment on attachment 377063 [details] Patch Clearing flags on attachment: 377063 Committed r249653: <https://trac.webkit.org/changeset/249653>
Daniel Bates
Comment 10 2019-09-09 11:56:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-09-09 11:57:23 PDT
<rdar://problem/55191985>
Radar WebKit Bug Importer
Comment 12 2019-09-09 11:57:24 PDT
<rdar://problem/55191983>
Note You need to log in before you can comment on or make changes to this bug.