Bug 199225 – [Payment Request] Perform payment method data IDL conversion in the PaymentRequest constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Andy Estes]

See https://github.com/w3c/payment-request/issues/813

[Radar WebKit Bug Importer]

<rdar://problem/52217847>

[Andy Estes]

Created attachment 386586 [details]
Patch

[Darin Adler]

Comment on attachment 386586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386586&action=review

Looks like there are failures in LayoutTests/http/tests/ssl/applepay/PaymentRequest.https.html

> Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:72
> +        return Exception { ExistingExceptionError };

Not new: So this is supposed to discard the original exception and replace it with ExistingExceptionError? Slightly surprised but I guess that’s a modern web platform design pattern?

> Source/WebCore/Modules/paymentrequest/PaymentHandler.cpp:71
> +    UNUSED_PARAM(document);

Why not sort these the same order as the order they are passed in?

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:320
> +    return WTFMove(data);

Not new: JSValue is a simple scalar so there’s no need to do WTFMove.

[Andy Estes]

Created attachment 386629 [details]
Patch

[Andy Estes]

(In reply to Darin Adler from comment #3)
> Comment on attachment 386586 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=386586&action=review
> 
> Looks like there are failures in
> LayoutTests/http/tests/ssl/applepay/PaymentRequest.https.html

Fixed.

> 
> > Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:72
> > +        return Exception { ExistingExceptionError };
> 
> Not new: So this is supposed to discard the original exception and replace
> it with ExistingExceptionError? Slightly surprised but I guess that’s a
> modern web platform design pattern?

ExistingExceptionError indicates to the bindings that the original VM exception should be propagated.

> 
> > Source/WebCore/Modules/paymentrequest/PaymentHandler.cpp:71
> > +    UNUSED_PARAM(document);
> 
> Why not sort these the same order as the order they are passed in?

Fixed.

> 
> > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:320
> > +    return WTFMove(data);
> 
> Not new: JSValue is a simple scalar so there’s no need to do WTFMove.

Fixed.

[WebKit Commit Bot]

Comment on attachment 386629 [details]
Patch

Clearing flags on attachment: 386629

Committed r253986: <https://trac.webkit.org/changeset/253986>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.