Bug 199223 - [SOUP] WebSockets: handle TLS certificate and errors
Summary: [SOUP] WebSockets: handle TLS certificate and errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 199151
Blocks:
  Show dependency tree / graph
 
Reported: 2019-06-26 05:30 PDT by Carlos Garcia Campos
Modified: 2019-06-27 01:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2019-06-26 05:33 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-06-26 05:30:57 PDT 
We need to decide based on the session policy.
Comment 1 Carlos Garcia Campos 2019-06-26 05:33:13 PDT 
Created attachment 372918 [details]
Patch
Comment 2 Michael Catanzaro 2019-06-26 06:55:04 PDT 
Comment on attachment 372918 [details]
Patch

So now this is a third place where we check the TLS certificate: (1) the normal non-WebSocket codepath, (2) SocketStreamHandleImplSoup.cpp for the previous WebSocket codepath, and (3) now here, for the new WebSocket codepath.

Correct?

I think this is OK if SocketStreamHandleImplSoup.cpp goes away and is no longer used with new WebSockets. Is that right?
Comment 3 Carlos Garcia Campos 2019-06-26 07:00:35 PDT 
Right, SocketStreamHandleImplSoup.cpp will be removed when we enable the new code patch.
Comment 4 Michael Catanzaro 2019-06-26 11:02:34 PDT 
Honestly it'd make more sense to include this in your patch adding the new WebSocket backend, but whatever.
Comment 5 Carlos Garcia Campos 2019-06-27 01:59:03 PDT 
Committed r246878: <https://trac.webkit.org/changeset/246878>