Bug 199193 - [ews-build] Combine various patchFailed*Tests properties
Summary: [ews-build] Combine various patchFailed*Tests properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-25 10:32 PDT by Aakash Jain
Modified: 2019-06-26 16:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.17 KB, patch)
2019-06-25 10:44 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (6.92 KB, patch)
2019-06-25 17:17 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-06-25 10:32:24 PDT
Combine various patchFailed*Tests properties. We don't need separate property for each type of test failure. 

These properties were initially added so that somes build-step can be statically added in build factory and would be executed/skipped based on these flags. This was mostly for build-steps which should be run only after failure, e.g.: UnApplyPatchIfRequired, CompileWebKitToT.

For most part, we don't require these flags anymore, since we started using addStepsAfterCurrentStep() method inside steps.py, which add such build-step dynamically as required (only after failure) (e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L638). But maybe it's still worth to keep them, as a safeguard against someone accidentally adding such steps in a wrong order in the factory.
Comment 1 Aakash Jain 2019-06-25 10:44:20 PDT
Created attachment 372841 [details]
Patch
Comment 2 Jonathan Bedard 2019-06-25 15:22:08 PDT
I would have expected tests to change with this sort of property modification.
Comment 3 Aakash Jain 2019-06-25 17:17:31 PDT
Created attachment 372883 [details]
Patch
Comment 4 Aakash Jain 2019-06-25 17:26:20 PDT
(In reply to Jonathan Bedard from comment #2)
> I would have expected tests to change with this sort of property modification.
Unit tests are modified for 'patchFailedJSCTests' property.

I just updated TestCompileWebKitToT.test_failure() and TestUnApplyPatchIfRequired.test_failure() so that these unit-test test 'patchFailedTests' property as well.
Comment 5 WebKit Commit Bot 2019-06-25 17:56:50 PDT
Comment on attachment 372883 [details]
Patch

Clearing flags on attachment: 372883

Committed r246822: <https://trac.webkit.org/changeset/246822>
Comment 6 WebKit Commit Bot 2019-06-25 17:56:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-06-26 16:13:13 PDT
<rdar://problem/52216813>
Comment 8 Radar WebKit Bug Importer 2019-06-26 16:13:14 PDT
<rdar://problem/52216815>