Bug 199180 - Migrate LayoutTests/http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store* test cases to setEnableFeature() and jsTestIsAsync
Summary: Migrate LayoutTests/http/tests/resourceLoadStatistics/clear-in-memory-and-per...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-24 18:53 PDT by John Wilander
Modified: 2019-06-25 13:48 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.25 KB, patch)
2019-06-24 18:56 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-06-24 18:53:58 PDT
The two LayoutTests/http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store* test cases should use setEnableFeature() and jsTestIsAsync.
Comment 1 Radar WebKit Bug Importer 2019-06-24 18:54:22 PDT
<rdar://problem/52085369>
Comment 2 John Wilander 2019-06-24 18:56:36 PDT
Created attachment 372814 [details]
Patch
Comment 3 Brent Fulgham 2019-06-25 13:06:17 PDT
Comment on attachment 372814 [details]
Patch

If nothing else, the test results look better with this approach. r=me
Comment 4 John Wilander 2019-06-25 13:21:01 PDT
Comment on attachment 372814 [details]
Patch

Thanks, Brent!
Comment 5 WebKit Commit Bot 2019-06-25 13:48:41 PDT
Comment on attachment 372814 [details]
Patch

Clearing flags on attachment: 372814

Committed r246804: <https://trac.webkit.org/changeset/246804>
Comment 6 WebKit Commit Bot 2019-06-25 13:48:43 PDT
All reviewed patches have been landed.  Closing bug.