Bug 199178 - [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
Summary: [ews-build] UploadTestResults and ExtractTestResults clobber results in case ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-24 16:55 PDT by Aakash Jain
Modified: 2019-06-25 09:18 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.26 KB, patch)
2019-06-24 16:59 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-06-24 16:55:58 PDT
UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build. We would need to retry layout-tests in EWS. However the file name for the uploaded test results is same if there are multiple layout-tests executions. The file name includes the builder-name, patch_id and build-number, all of which are same for multiple layout-test runs in a same build. We should add an optional identifier which can be passed to these classes in order to avoid clobbering the results.
Comment 1 Aakash Jain 2019-06-24 16:59:03 PDT
Created attachment 372810 [details]
Patch
Comment 2 Aakash Jain 2019-06-24 16:59:46 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/35/builds/11
Comment 3 Build Bot 2019-06-24 17:02:38 PDT Comment hidden (obsolete)
Comment 4 WebKit Commit Bot 2019-06-25 09:17:49 PDT
Comment on attachment 372810 [details]
Patch

Clearing flags on attachment: 372810

Committed r246793: <https://trac.webkit.org/changeset/246793>
Comment 5 WebKit Commit Bot 2019-06-25 09:17:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-06-25 09:18:18 PDT
<rdar://problem/52116313>