WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199178
[ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
https://bugs.webkit.org/show_bug.cgi?id=199178
Summary
[ews-build] UploadTestResults and ExtractTestResults clobber results in case ...
Aakash Jain
Reported
2019-06-24 16:55:58 PDT
UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build. We would need to retry layout-tests in EWS. However the file name for the uploaded test results is same if there are multiple layout-tests executions. The file name includes the builder-name, patch_id and build-number, all of which are same for multiple layout-test runs in a same build. We should add an optional identifier which can be passed to these classes in order to avoid clobbering the results.
Attachments
Patch
(6.26 KB, patch)
2019-06-24 16:59 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-06-24 16:59:03 PDT
Created
attachment 372810
[details]
Patch
Aakash Jain
Comment 2
2019-06-24 16:59:46 PDT
Sample run:
https://ews-build.webkit-uat.org/#/builders/35/builds/11
EWS Watchlist
Comment 3
2019-06-24 17:02:38 PDT
Comment hidden (obsolete)
Attachment 372810
[details]
did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:1104: [ExtractTestResults.__init__] Use of super on an old style class [pylint/E1002] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1491: [TestUploadTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1535: [TestExtractTestResults.test_success_with_identifier] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4
2019-06-25 09:17:49 PDT
Comment on
attachment 372810
[details]
Patch Clearing flags on attachment: 372810 Committed
r246793
: <
https://trac.webkit.org/changeset/246793
>
WebKit Commit Bot
Comment 5
2019-06-25 09:17:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-06-25 09:18:18 PDT
<
rdar://problem/52116313
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug