Bug 199164 - Remove IsITPFirstPartyWebsiteDataRemovalEnabled as runtime check
Summary: Remove IsITPFirstPartyWebsiteDataRemovalEnabled as runtime check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-24 11:06 PDT by John Wilander
Modified: 2019-06-24 14:37 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.34 KB, patch)
2019-06-24 11:11 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-06-24 11:06:48 PDT
We've had this toggle as a safety thing since mid-March. No need for it any longer.
Comment 1 Radar WebKit Bug Importer 2019-06-24 11:07:20 PDT
<rdar://problem/52061147>
Comment 2 John Wilander 2019-06-24 11:11:59 PDT
Created attachment 372772 [details]
Patch
Comment 3 John Wilander 2019-06-24 13:08:46 PDT
The win build error seems weird and unrelated:

  Processing document /home/buildbot/WebKit/Source/WebCore/Modules/mediastream/MediaDevices.idl did not generate anything at /home/buildbot/WebKit/Source/WebCore/bindings/scripts/CodeGenerator.pm line 243.
  Generating ../../DerivedSources/JavaScriptCore/JSInternalPromiseConstructor.lut.h
  Generating ../../DerivedSources/JavaScriptCore/JSModuleLoader.lut.h
  Generating ../../DerivedSources/JavaScriptCore/JSONObject.lut.h
  Generating ../../DerivedSources/JavaScriptCore/JSPromiseConstructor.lut.h
  Generating ../../DerivedSources/JavaScriptCore/JSPromisePrototype.lut.h
  Generating ../../DerivedSources/JavaScriptCore/MapPrototype.lut.h
  Generating ../../DerivedSources/JavaScriptCore/NumberConstructor.lut.h
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code 1. [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreBindings.vcxproj]
Comment 4 Brent Fulgham 2019-06-24 13:25:21 PDT
Comment on attachment 372772 [details]
Patch

Agreed -- I don't think the Windows thing is related to your patch. Maybe it needs to be kicked into a clean build because of the WebPreferences.yaml change?
Comment 5 John Wilander 2019-06-24 14:07:21 PDT
Comment on attachment 372772 [details]
Patch

Thanks, Brent!
Comment 6 WebKit Commit Bot 2019-06-24 14:37:32 PDT
Comment on attachment 372772 [details]
Patch

Clearing flags on attachment: 372772

Committed r246763: <https://trac.webkit.org/changeset/246763>
Comment 7 WebKit Commit Bot 2019-06-24 14:37:33 PDT
All reviewed patches have been landed.  Closing bug.