"status" : "contributor", added all over the place in r243297 "Update status inactive committers' status to 'contributor'," isn't recognized as canonical format by validate-committer-lists --canonicalize. Canonicalizing contributors.json will result in the removal of "status" : "contributor" wherever it exists. We could make it canonical form with this simple tweak: diff --git a/Tools/Scripts/webkitpy/common/config/committers.py b/Tools/Scripts/ webkitpy/common/config/committers.py index ed927ba52ea..c446ce53a04 100644 --- a/Tools/Scripts/webkitpy/common/config/committers.py +++ b/Tools/Scripts/webkitpy/common/config/committers.py @@ -142,6 +142,8 @@ class Contributor(object): info["status"] = "reviewer" elif self.can_commit: info["status"] = "committer" + else: + info["status"] = "contributor" if self.irc_nicknames: info["nicks"] = self.irc_nicknames Or we could just remove it everywhere. Alexey, your preference?
This patch canonicalizes it without changing the format.
Created attachment 372764 [details] Patch
(In reply to Michael Catanzaro from comment #0) > We could make it canonical form with this simple tweak: (Note this will result in it being added in a ton of places where it's not currently.)
Attachment 372764 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372764 [details] Patch No preference as far as I’m concerned. I didn’t know that there was a canonical form.
Committed r246751: <https://trac.webkit.org/changeset/246751>
<rdar://problem/52063832>