Bug 199159 - Fully rename WebKitGTK+ -> WebKitGTK everywhere
Summary: Fully rename WebKitGTK+ -> WebKitGTK everywhere
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-24 08:01 PDT by Michael Catanzaro
Modified: 2019-06-25 07:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch (59.00 KB, patch)
2019-06-24 08:04 PDT, Michael Catanzaro
cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-06-24 08:01:17 PDT
Fully rename WebKitGTK+ -> WebKitGTK everywhere. Now with 100% less punctuation!

I riskily touched some webkitpy files, so let's see if webkitpy touches on EWS.
Comment 1 Michael Catanzaro 2019-06-24 08:04:45 PDT
Created attachment 372760 [details]
Patch
Comment 2 EWS Watchlist 2019-06-24 08:08:20 PDT
Attachment 372760 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp"
WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp"
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2019-06-25 00:50:22 PDT
Comment on attachment 372760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372760&action=review

Do not change the NEWS file.

> Source/WebKit/gtk/NEWS:5
> +What's new in WebKitGTK 2.25.3?

?
Comment 4 Michael Catanzaro 2019-06-25 07:55:40 PDT
(In reply to Carlos Garcia Campos from comment #3)
> Do not change the NEWS file.
> 
> > Source/WebKit/gtk/NEWS:5
> > +What's new in WebKitGTK 2.25.3?
> 
> ?

I added that there as a placeholder for you, because you keep forgetting to remove the +. Don't forget!
Comment 5 Michael Catanzaro 2019-06-25 07:56:44 PDT
Committed r246790: <https://trac.webkit.org/changeset/246790>