Bug 199157 - [LFC][IFC] Inline runs should be relative to the line's top/left initially
Summary: [LFC][IFC] Inline runs should be relative to the line's top/left initially
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2019-06-24 07:36 PDT by zalan
Modified: 2019-07-05 07:24 PDT (History)
6 users (show)

See Also:

Patch (4.23 KB, patch)
2019-06-24 08:05 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-06-24 07:36:55 PDT
so that when the line is moved (floats etc) the individual runs don't need to be moved too.
Comment 1 Radar WebKit Bug Importer 2019-06-24 07:37:39 PDT
Comment 2 zalan 2019-06-24 08:05:43 PDT
Created attachment 372761 [details]
Comment 3 Antti Koivisto 2019-07-05 06:26:48 PDT
Comment on attachment 372761 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=372761&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.cpp:139
> +            // Convert runs from relative to the line top/left to the formatting root's border box top/left.
> +            run->logicalRect.moveVertically(this->logicalTop());
> +            run->logicalRect.moveHorizontally(this->logicalLeft());

Comment 4 WebKit Commit Bot 2019-07-05 07:24:29 PDT
Comment on attachment 372761 [details]

Clearing flags on attachment: 372761

Committed r247153: <https://trac.webkit.org/changeset/247153>
Comment 5 WebKit Commit Bot 2019-07-05 07:24:30 PDT
All reviewed patches have been landed.  Closing bug.