Bug 199154 - Add user agent quirk for bankofamerica.com
Summary: Add user agent quirk for bankofamerica.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-24 07:02 PDT by Michael Catanzaro
Modified: 2019-06-25 07:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.67 KB, patch)
2019-06-24 07:03 PDT, Michael Catanzaro
cgarcia: review+
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.17 MB, application/zip)
2019-06-24 13:41 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-06-24 07:02:32 PDT
Add user agent quirk for bankofamerica.com to suppress its unsupported browser warning.
Comment 1 Michael Catanzaro 2019-06-24 07:03:42 PDT
Created attachment 372753 [details]
Patch
Comment 2 Michael Catanzaro 2019-06-24 08:02:10 PDT
Comment on attachment 372753 [details]
Patch

Should be landed with WebKitGTK comment rather than WebKitGTK+.
Comment 3 EWS Watchlist 2019-06-24 13:41:27 PDT
Comment on attachment 372753 [details]
Patch

Attachment 372753 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12564239

New failing tests:
storage/indexeddb/index-cursor.html
css3/filters/blur-various-radii.html
Comment 4 EWS Watchlist 2019-06-24 13:41:30 PDT
Created attachment 372797 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 5 Carlos Garcia Campos 2019-06-25 00:59:01 PDT
Comment on attachment 372753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372753&action=review

> Source/WebCore/platform/UserAgentQuirks.cpp:112
> +    // Bank of America shows an unsupported browser warning with WebKitGTK+'s

WebKitGTK+? really? :-)
Comment 6 Michael Catanzaro 2019-06-25 07:58:44 PDT
(In reply to Carlos Garcia Campos from comment #5)
> WebKitGTK+? really? :-)

Yeah, merge conflict! Aaaah!
Comment 7 Michael Catanzaro 2019-06-25 07:59:22 PDT
Committed r246791: <https://trac.webkit.org/changeset/246791>