Bug 199153 - Add user agent quirk for Google Drive
Summary: Add user agent quirk for Google Drive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-24 06:54 PDT by Michael Catanzaro
Modified: 2021-02-17 07:08 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2019-06-24 06:55 PDT, Michael Catanzaro 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-06-24 06:54:24 PDT 
Add user agent quirk for Google Drive to suppress its unsupported browser warning
Comment 1 Michael Catanzaro 2019-06-24 06:55:57 PDT 
Created attachment 372752 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-06-24 07:01:21 PDT 
Comment on attachment 372752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372752&action=review

> Source/WebCore/platform/UserAgentQuirks.cpp:108
>      // Google Docs shows a scary unsupported browser warning with WebKitGTK+'s
>      // standard user agent.

You could take the opportunity to remove that + too :-) And update the comment to say it also happens with drive.
Comment 3 Michael Catanzaro 2019-06-24 07:34:52 PDT 
I'll remove the pluses in a follow-up since there are a lot in this file.

(In reply to Carlos Garcia Campos from comment #2)
> And update the comment to say it also happens with drive.

OK.
Comment 4 Michael Catanzaro 2019-06-24 07:35:46 PDT 
Committed r246733: <https://trac.webkit.org/changeset/246733>