WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199153
Add user agent quirk for Google Drive
https://bugs.webkit.org/show_bug.cgi?id=199153
Summary
Add user agent quirk for Google Drive
Michael Catanzaro
Reported
2019-06-24 06:54:24 PDT
Add user agent quirk for Google Drive to suppress its unsupported browser warning
Attachments
Patch
(3.40 KB, patch)
2019-06-24 06:55 PDT
,
Michael Catanzaro
cgarcia
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2019-06-24 06:55:57 PDT
Created
attachment 372752
[details]
Patch
Carlos Garcia Campos
Comment 2
2019-06-24 07:01:21 PDT
Comment on
attachment 372752
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=372752&action=review
> Source/WebCore/platform/UserAgentQuirks.cpp:108 > // Google Docs shows a scary unsupported browser warning with WebKitGTK+'s > // standard user agent.
You could take the opportunity to remove that + too :-) And update the comment to say it also happens with drive.
Michael Catanzaro
Comment 3
2019-06-24 07:34:52 PDT
I'll remove the pluses in a follow-up since there are a lot in this file. (In reply to Carlos Garcia Campos from
comment #2
)
> And update the comment to say it also happens with drive.
OK.
Michael Catanzaro
Comment 4
2019-06-24 07:35:46 PDT
Committed
r246733
: <
https://trac.webkit.org/changeset/246733
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug