Bug 199149 - [ews-build] Enable iOS-12-Build queue on new EWS
Summary: [ews-build] Enable iOS-12-Build queue on new EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-24 04:59 PDT by Aakash Jain
Modified: 2019-06-24 12:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.61 KB, patch)
2019-06-24 05:12 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-06-24 04:59:02 PDT 
Enable iOS-12-Build queue on new EWS in production.
Comment 1 Aakash Jain 2019-06-24 05:12:53 PDT 
Created attachment 372746 [details]
Patch
Comment 2 Aakash Jain 2019-06-24 05:16:09 PDT 
Note that this queue doesn't run layout-tests (we run layout-tests only on iOS simulator, not on iOS devices).

Sample runs:
Success: https://ews-build.webkit-uat.org/#/builders/38/builds/2
ToT Failure: https://ews-build.webkit-uat.org/#/builders/38/builds/13
Patch Failure: https://ews-build.webkit-uat.org/#/builders/38/builds/16
Comment 3 Jonathan Bedard 2019-06-24 07:18:09 PDT 
Comment on attachment 372746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372746&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42
> +    ALL_QUEUES = ['ios', 'api-ios', 'api-mac', 'bindings', 'gtk', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2',

Why did we change this order?

> Tools/BuildSlaveSupport/ews-build/config.json:295
> +      "workernames": ["ews152", "ews154", "ews108", "ews109"]

You mention in your changelog that we're sharing temporarily...why temporarily? This seems like a good idea more generally.
Comment 4 Aakash Jain 2019-06-24 07:39:36 PDT 
Comment on attachment 372746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372746&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42
>> +    ALL_QUEUES = ['ios', 'api-ios', 'api-mac', 'bindings', 'gtk', 'ios-sim', 'ios-wk2', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2',
> 
> Why did we change this order?

So as to display the iOS bubble on the left. e.g.: https://ews.webkit-uat.org/status-bubble/372719/

I mentioned in ChangeLog: "Also display the ios bubble first (left). Going forward will keep the builders to the left and testers to the right."

>> Tools/BuildSlaveSupport/ews-build/config.json:295
>> +      "workernames": ["ews152", "ews154", "ews108", "ews109"]
> 
> You mention in your changelog that we're sharing temporarily...why temporarily? This seems like a good idea more generally.

We can leave them shared as well if we feel that this sharing is helping on this queue.

This is required currently until move ews108 and ews109 from old to new EWS <rdar://problem/52051091>.
Comment 5 WebKit Commit Bot 2019-06-24 08:26:55 PDT 
Comment on attachment 372746 [details]
Patch

Clearing flags on attachment: 372746

Committed r246738: <https://trac.webkit.org/changeset/246738>
Comment 6 WebKit Commit Bot 2019-06-24 08:26:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-06-24 08:27:15 PDT 
<rdar://problem/52054574>
Comment 8 Aakash Jain 2019-06-24 12:25:27 PDT 
Deployed the change to the production. 'ios' bubble is now visible in new EWS bubbles.