RESOLVED FIXED 199136
Web Inspector: REGRESSION (r246684): Dark Mode: dashboard buttons should have no background 
https://bugs.webkit.org/show_bug.cgi?id=199136
Summary Web Inspector: REGRESSION (r246684): Dark Mode: dashboard buttons should have...
Matt Baker
Reported 2019-06-23 14:16:03 PDT
Broke when the following rule was removed from DefaultDashboardView.css: - body.latest-mac .toolbar .dashboard .item.button { - background: unset; - } Without `body.latest-mac` this selector wouldn't have a high enough specificity to override the ButtonToolbarItem rule that adds the background color. We can fix this with a new rule in DefaultDashboardView.css: @media (prefers-color-scheme: dark) { .toolbar .dashboard .item.button, .toolbar .dashboard .item.button:active { background: none; } } Regressed in https://trac.webkit.org/changeset/246684.
Attachments
[Image] resume button - dark mode (19.85 KB, image/png)
2019-06-23 14:29 PDT, Matt Baker 		no flags
Details
Patch (1.62 KB, patch)
2019-06-23 14:32 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-23 14:16:17 PDT
<rdar://problem/52035798>
Matt Baker
Comment 2 2019-06-23 14:29:47 PDT
Created attachment 372710 [details] [Image] resume button - dark mode
Matt Baker
Comment 3 2019-06-23 14:32:03 PDT
Created attachment 372711 [details] Patch
Joseph Pecoraro
Comment 4 2019-06-23 15:05:10 PDT
Comment on attachment 372711 [details] Patch rs=me
WebKit Commit Bot
Comment 5 2019-06-23 15:36:33 PDT
Comment on attachment 372711 [details] Patch Clearing flags on attachment: 372711 Committed r246724: <https://trac.webkit.org/changeset/246724>
WebKit Commit Bot
Comment 6 2019-06-23 15:36:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.