Bug 199136 - Web Inspector: REGRESSION (r246684): Dark Mode: dashboard buttons should have no background
Summary: Web Inspector: REGRESSION (r246684): Dark Mode: dashboard buttons should have...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-23 14:16 PDT by Matt Baker
Modified: 2019-06-23 15:36 PDT (History)
5 users (show)

See Also:


Attachments
[Image] resume button - dark mode (19.85 KB, image/png)
2019-06-23 14:29 PDT, Matt Baker
no flags Details
Patch (1.62 KB, patch)
2019-06-23 14:32 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2019-06-23 14:16:03 PDT
Broke when the following rule was removed from DefaultDashboardView.css:

- body.latest-mac .toolbar .dashboard .item.button {
-     background: unset;
- }

Without `body.latest-mac` this selector wouldn't have a high enough specificity to override the ButtonToolbarItem rule that adds the background color. We can fix this with a new rule in DefaultDashboardView.css:

@media (prefers-color-scheme: dark) {
    .toolbar .dashboard .item.button,
    .toolbar .dashboard .item.button:active {
        background: none;
    }
}

Regressed in https://trac.webkit.org/changeset/246684.
Comment 1 Radar WebKit Bug Importer 2019-06-23 14:16:17 PDT
<rdar://problem/52035798>
Comment 2 Matt Baker 2019-06-23 14:29:47 PDT
Created attachment 372710 [details]
[Image] resume button - dark mode
Comment 3 Matt Baker 2019-06-23 14:32:03 PDT
Created attachment 372711 [details]
Patch
Comment 4 Joseph Pecoraro 2019-06-23 15:05:10 PDT
Comment on attachment 372711 [details]
Patch

rs=me
Comment 5 WebKit Commit Bot 2019-06-23 15:36:33 PDT
Comment on attachment 372711 [details]
Patch

Clearing flags on attachment: 372711

Committed r246724: <https://trac.webkit.org/changeset/246724>
Comment 6 WebKit Commit Bot 2019-06-23 15:36:34 PDT
All reviewed patches have been landed.  Closing bug.