RESOLVED FIXED 199125
REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule 
https://bugs.webkit.org/show_bug.cgi?id=199125
Summary REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last proper...
Nikita Vasilyev
Reported 2019-06-21 19:06:01 PDT
Focus event handler was removed in https://trac.webkit.org/changeset/241980/webkit. This no longer starts editing selector: startEditingRuleSelector() { ... if (this._style.selectorEditable) this._selectorElement.focus();
Attachments
[Animated GIF] Bug (85.35 KB, image/gif)
2019-06-21 19:08 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.69 KB, patch)
2019-06-21 19:13 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-06-21 19:06:15 PDT
<rdar://problem/52011182>
Nikita Vasilyev
Comment 2 2019-06-21 19:08:08 PDT
Created attachment 372667 [details] [Animated GIF] Bug
Nikita Vasilyev
Comment 3 2019-06-21 19:13:48 PDT
Created attachment 372668 [details] Patch
Matt Baker
Comment 4 2019-06-22 10:56:44 PDT
Comment on attachment 372668 [details] Patch r=me, works as advertised! I noticed we show the green "change added" treatment for newly added blank properties. Maybe we should delay doing this until some property name text is actually entered.
WebKit Commit Bot
Comment 5 2019-06-22 11:28:08 PDT
Comment on attachment 372668 [details] Patch Clearing flags on attachment: 372668 Committed r246713: <https://trac.webkit.org/changeset/246713>
WebKit Commit Bot
Comment 6 2019-06-22 11:28:10 PDT
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 7 2019-06-22 16:33:18 PDT
(In reply to Matt Baker from comment #4) > Comment on attachment 372668 [details] > Patch > > r=me, works as advertised! > > I noticed we show the green "change added" treatment for newly added blank > properties. Maybe we should delay doing this until some property name text > is actually entered. Posted a patch in Bug 199131 - Web Inspector: Styles: show green highlight for newly added properties only when name and value are present
Note You need to log in before you can comment on or make changes to this bug.