Bug 199125 - REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule
Summary: REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last proper...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-21 19:06 PDT by Nikita Vasilyev
Modified: 2019-06-22 16:33 PDT (History)
4 users (show)

See Also:

Attachments
[Animated GIF] Bug (85.35 KB, image/gif)
2019-06-21 19:08 PDT, Nikita Vasilyev 		no flags Details
Patch (1.69 KB, patch)
2019-06-21 19:13 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-06-21 19:06:01 PDT 
Focus event handler was removed in https://trac.webkit.org/changeset/241980/webkit.

This no longer starts editing selector:

    startEditingRuleSelector()
    {
        ...
        if (this._style.selectorEditable)
            this._selectorElement.focus();
Comment 1 Radar WebKit Bug Importer 2019-06-21 19:06:15 PDT 
<rdar://problem/52011182>
Comment 2 Nikita Vasilyev 2019-06-21 19:08:08 PDT 
Created attachment 372667 [details]
[Animated GIF] Bug
Comment 3 Nikita Vasilyev 2019-06-21 19:13:48 PDT 
Created attachment 372668 [details]
Patch
Comment 4 Matt Baker 2019-06-22 10:56:44 PDT 
Comment on attachment 372668 [details]
Patch

r=me, works as advertised!

I noticed we show the green "change added" treatment for newly added blank properties. Maybe we should delay doing this until some property name text is actually entered.
Comment 5 WebKit Commit Bot 2019-06-22 11:28:08 PDT 
Comment on attachment 372668 [details]
Patch

Clearing flags on attachment: 372668

Committed r246713: <https://trac.webkit.org/changeset/246713>
Comment 6 WebKit Commit Bot 2019-06-22 11:28:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Nikita Vasilyev 2019-06-22 16:33:18 PDT 
(In reply to Matt Baker from comment #4)
> Comment on attachment 372668 [details]
> Patch
> 
> r=me, works as advertised!
> 
> I noticed we show the green "change added" treatment for newly added blank
> properties. Maybe we should delay doing this until some property name text
> is actually entered.

Posted a patch in Bug 199131 - Web Inspector: Styles: show green highlight for newly added properties only when name and value are present