Bug 19912 - stl::* symbols unexpectedly exported
Summary: stl::* symbols unexpectedly exported
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Mike Hommey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-06 05:14 PDT by Mike Hommey
Modified: 2008-08-27 18:24 PDT (History)
1 user (show)

See Also:


Attachments
patch (801 bytes, patch)
2008-07-06 05:15 PDT, Mike Hommey
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Hommey 2008-07-06 05:14:21 PDT
Because of http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36022, a lot of std::* weak symbols are exported for STL templates, which is not really something wanted (especially since the set of symbols is different depending on the optimization level).
Comment 1 Mike Hommey 2008-07-06 05:15:12 PDT
Created attachment 22106 [details]
patch

This is the work-around I came up with for Debian.
Comment 2 Mike Hommey 2008-07-10 12:16:57 PDT
Note that ARM gcc has an interesting bug that makes all vtables and vtts to be exported despite being defined visibility hidden. For the moment, I replaced _ZSt*;
_ZNSt*;
with
_Z*;
on Debian.
Comment 3 Holger Freyther 2008-07-17 09:41:27 PDT
Comment on attachment 22106 [details]
patch

Okay. We don't have a coding style for these kind of files but wouldn't it be more obvious if _ZSt*; and _ZNSt*; would be in the same line as local? or at least indented?

What do you think about the following (less conservative) change?

global: webkit_*;
local: *;

besides I wonder if people use WebKit without the GNU or sun linker.
Comment 4 Jan Alonzo 2008-08-06 05:02:07 PDT
(In reply to comment #3)
> (From update of attachment 22106 [details] [edit])
> Okay. We don't have a coding style for these kind of files but wouldn't it be
> more obvious if _ZSt*; and _ZNSt*; would be in the same line as local? or at
> least indented?
> 
> What do you think about the following (less conservative) change?
> 
> global: webkit_*;
> local: *;
> 
> besides I wonder if people use WebKit without the GNU or sun linker.

Holger, Mike: 

Before committing, Is it ok to move symbols.filter in (srcdir)/WebKit/gtk rather than in the top-level srcdir?
Comment 5 Holger Freyther 2008-08-27 18:24:33 PDT
Landed in r35957. We can move the symbols file now if we want to.