Bug 19912 – stl::* symbols unexpectedly exported

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mike Hommey]

Because of http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36022, a lot of std::* weak symbols are exported for STL templates, which is not really something wanted (especially since the set of symbols is different depending on the optimization level).

[Mike Hommey]

Created attachment 22106 [details]
patch

This is the work-around I came up with for Debian.

[Mike Hommey]

Note that ARM gcc has an interesting bug that makes all vtables and vtts to be exported despite being defined visibility hidden. For the moment, I replaced _ZSt*;
_ZNSt*;
with
_Z*;
on Debian.

[Holger Freyther]

Comment on attachment 22106 [details]
patch

Okay. We don't have a coding style for these kind of files but wouldn't it be more obvious if _ZSt*; and _ZNSt*; would be in the same line as local? or at least indented?

What do you think about the following (less conservative) change?

global: webkit_*;
local: *;

besides I wonder if people use WebKit without the GNU or sun linker.

[Jan Alonzo]

(In reply to comment #3)
> (From update of attachment 22106 [details] [edit])
> Okay. We don't have a coding style for these kind of files but wouldn't it be
> more obvious if _ZSt*; and _ZNSt*; would be in the same line as local? or at
> least indented?
> 
> What do you think about the following (less conservative) change?
> 
> global: webkit_*;
> local: *;
> 
> besides I wonder if people use WebKit without the GNU or sun linker.

Holger, Mike: 

Before committing, Is it ok to move symbols.filter in (srcdir)/WebKit/gtk rather than in the top-level srcdir?

[Holger Freyther]

Landed in r35957. We can move the symbols file now if we want to.