Bug 199111 - Address reference to UIColor.groupTableViewBackgroundColor in WKPasswordView.mm
Summary: Address reference to UIColor.groupTableViewBackgroundColor in WKPasswordView.mm
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-06-21 10:24 PDT by Keith Rollin
Modified: 2019-06-21 12:12 PDT (History)
4 users (show)

See Also:

Patch (2.00 KB, patch)
2019-06-21 10:25 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-06-21 10:24:03 PDT
WKPasswordView.mm is used on iOS-family devices. However, it doesn't build on tvOS or watchOS when "treat deprecation warnings as errors" is enabled. This build failure is due to a reference to UIColor.groupTableViewBackgroundColor in a branch of non-dark-mode code. Address this by surrounding the reference with ALLOW_DEPRECATED_DECLARATIONS_* macros.

Attempting to address the build failure by unconditionally enabling the dark-mode code works for tvOS, but fails for watchOS due to lack of dark-mode support on that platform.
Comment 1 Radar WebKit Bug Importer 2019-06-21 10:24:18 PDT
Comment 2 Keith Rollin 2019-06-21 10:25:29 PDT
Created attachment 372633 [details]
Comment 3 WebKit Commit Bot 2019-06-21 12:12:50 PDT
Comment on attachment 372633 [details]

Clearing flags on attachment: 372633

Committed r246687: <https://trac.webkit.org/changeset/246687>
Comment 4 WebKit Commit Bot 2019-06-21 12:12:51 PDT
All reviewed patches have been landed.  Closing bug.