Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.

[Andres Gonzalez]

Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.

[Andres Gonzalez]

Created attachment 372628 [details]
Patch

[chris fleizach]

Comment on attachment 372628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372628&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1035
> +    // If this has a link ancestor, check for the aria-haspopup attribute in the ancestor.

I think we can write this whole method as

return AccessibilityObject::matchedParent(*this, true, [&role] (const AccessibilityObject& object) {
        return !equalLettersIgnoringASCIICase(object.hasPopupValue()), "false");
    });

> LayoutTests/accessibility/ios-simulator/button-with-aria-haspopup-role-expected.txt:15
> +test10 AXTraits: 8256 for aria-haspopup=''

it's probably risky to output the actual value of the traits which may change over time. maybe better to verify that the traits are different for an object that has popup and one that does not

[Andres Gonzalez]

Created attachment 372644 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372644 [details]
Patch

Clearing flags on attachment: 372644

Committed r246715: <https://trac.webkit.org/changeset/246715>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52021559>