Bug 199104 – [GTK] Navigation gesture should use dark fallback bg color on dark themes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alice Mikhaylenko]

See the patch.

[Alice Mikhaylenko]

Created attachment 372621 [details]
Patch

[EWS Watchlist]

Comment on attachment 372621 [details]
Patch

Attachment 372621 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12540364

New failing tests:
storage/indexeddb/index-cursor.html

[EWS Watchlist]

Created attachment 372626 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Michael Catanzaro]

Comment on attachment 372621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372621&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:322
> +        gtk_style_context_lookup_color(context, "theme_base_color", &color);

Is this an Adwaita-ism? What happens if the theme doesn't have a theme_base_color? Will the GdkRGBA contain uninitialized memory? Do we need a fallback?

[Alice Mikhaylenko]

Good question. It is listed as a public color, and elementary also has it (I tested on that one too specifically). But worth to double-check, agree.

[Michael Catanzaro]

Better add a fallback if there's any possibility the GdkRGBA could be uninitialized.

[Alice Mikhaylenko]

Created attachment 372629 [details]
Patch

[Alice Mikhaylenko]

(In reply to Michael Catanzaro from comment #6)
> Better add a fallback if there's any possibility the GdkRGBA could be
> uninitialized.

Yeah, agree. Realistically, `win32` theme may be missing it.

[WebKit Commit Bot]

Comment on attachment 372629 [details]
Patch

Clearing flags on attachment: 372629

Committed r246732: <https://trac.webkit.org/changeset/246732>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.