.
Created attachment 372608 [details] Patch
Comment on attachment 372608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372608&action=review > Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80 > + shadowRootPushed(parentNodeId, payload) This doesn't match the name in the protocol either. It should be `hostId` and `root`.
(In reply to Devin Rousso from comment #2) > Comment on attachment 372608 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372608&action=review > > > Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80 > > + shadowRootPushed(parentNodeId, payload) > > This doesn't match the name in the protocol either. It should be `hostId` > and `root`. I chose a poor name for this bug. I wanted to use payload to be consistent with other DOMObserver methods, setChildNodes and childNodeInserted. I can rename payload and payloads in those to match the respective names in the protocol.
Created attachment 372612 [details] Patch
Comment on attachment 372612 [details] Patch rs=me
Comment on attachment 372612 [details] Patch Clearing flags on attachment: 372612 Committed r246672: <https://trac.webkit.org/changeset/246672>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51975578>