Bug 199098 - Web Inspector: rename some DOMObserver method parameters to match the protocol
Summary: Web Inspector: rename some DOMObserver method parameters to match the protocol
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-20 19:08 PDT by Matt Baker
Modified: 2019-06-20 22:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2019-06-20 19:10 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
Patch (2.54 KB, patch)
2019-06-20 19:37 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2019-06-20 19:08:10 PDT
.
Comment 1 Matt Baker 2019-06-20 19:10:30 PDT
Created attachment 372608 [details]
Patch
Comment 2 Devin Rousso 2019-06-20 19:15:55 PDT
Comment on attachment 372608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372608&action=review

> Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80
> +    shadowRootPushed(parentNodeId, payload)

This doesn't match the name in the protocol either.  It should be `hostId` and `root`.
Comment 3 Matt Baker 2019-06-20 19:20:03 PDT
(In reply to Devin Rousso from comment #2)
> Comment on attachment 372608 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372608&action=review
> 
> > Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js:80
> > +    shadowRootPushed(parentNodeId, payload)
> 
> This doesn't match the name in the protocol either.  It should be `hostId`
> and `root`.

I chose a poor name for this bug. I wanted to use payload to be consistent with other DOMObserver methods, setChildNodes and childNodeInserted.

I can rename payload and payloads in those to match the respective names in the protocol.
Comment 4 Matt Baker 2019-06-20 19:37:03 PDT
Created attachment 372612 [details]
Patch
Comment 5 Devin Rousso 2019-06-20 22:11:58 PDT
Comment on attachment 372612 [details]
Patch

rs=me
Comment 6 WebKit Commit Bot 2019-06-20 22:44:08 PDT
Comment on attachment 372612 [details]
Patch

Clearing flags on attachment: 372612

Committed r246672: <https://trac.webkit.org/changeset/246672>
Comment 7 WebKit Commit Bot 2019-06-20 22:44:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-20 22:48:15 PDT
<rdar://problem/51975578>