RESOLVED FIXED 199097
Make sure to check for file descriptor value before using FD_CLR 
https://bugs.webkit.org/show_bug.cgi?id=199097
Summary Make sure to check for file descriptor value before using FD_CLR
youenn fablet
Reported 2019-06-20 19:05:01 PDT
Make sure to check for file descriptor value before using FD_CLR
Attachments
Patch (3.93 KB, patch)
2019-06-20 19:12 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-06-20 19:05:25 PDT
<rdar://problem/51479074>
youenn fablet
Comment 2 2019-06-20 19:12:37 PDT
Created attachment 372609 [details] Patch
Eric Carlson
Comment 3 2019-06-21 09:43:18 PDT
Comment on attachment 372609 [details] Patch Is it worth adding a GetDescriptor() check in ProcessEvents, or is getsockopt() with an invalid file descriptor harmless?
youenn fablet
Comment 4 2019-06-21 10:06:31 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 372609 [details] > Patch > > Is it worth adding a GetDescriptor() check in ProcessEvents, or is > getsockopt() with an invalid file descriptor harmless? I think this is fine, ProcessEvents should only be called with a dispatcher with a valid descriptor.
WebKit Commit Bot
Comment 5 2019-06-21 10:12:42 PDT
Comment on attachment 372609 [details] Patch Clearing flags on attachment: 372609 Committed r246682: <https://trac.webkit.org/changeset/246682>
WebKit Commit Bot
Comment 6 2019-06-21 10:12:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.