Bug 199093 – [WHLSL] Import bitwise bool tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

The following code fails to compile in the checker:

[numthreads(1, 1, 1)]
compute void _compute_main(device bool[] result : register(u0))
{
     result[0] = true;
}

However, it works if int/uint/uchar/float or float4 is substituted for bool (with a matching literal assignment).

[Justin Fan]

Neither replacing the 'true' literal with '0 == 0' or the body with:

bool b = 0 == 0;
result[0] = b;

were successful past the checker.

[Justin Fan]

The following code also fails in the checker:

[numthreads(1, 1, 1)]
compute void _compute_main(device bool[] result : register(u0)) {}

However, replacing 'bool' with 'int' successfully compiles.

[Saam Barati]

Have a fix. We're failing in PODChecker.

[Saam Barati]

This is on purpose for various reasons. The main one being we aren't specifying bool's bit pattern. So we are going to make the harness work around this.

[Saam Barati]

Created attachment 373056 [details]
WIP

[Saam Barati]

Created attachment 373248 [details]
patch

[WebKit Commit Bot]

Comment on attachment 373248 [details]
patch

Clearing flags on attachment: 373248

Committed r247067: <https://trac.webkit.org/changeset/247067>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52537914>

[Truitt Savell]

Looks like the new test webgpu/whlsl-bitwise-bool-ops.html

added in https://trac.webkit.org/changeset/247067/webkit

is timing out on Mojave Debug WK2

History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fwhlsl-bitwise-bool-ops.html