Bug 199083 - [iOS] Evernote crashes when creating a note
Summary: [iOS] Evernote crashes when creating a note
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2019-06-20 15:26 PDT by Daniel Bates
Modified: 2019-06-20 17:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.86 KB, patch)
2019-06-20 15:45 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2019-06-20 15:51 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-06-20 15:26:34 PDT
Evernote crashes when creating a note in iOS 13.
Comment 1 Daniel Bates 2019-06-20 15:26:43 PDT
<rdar://problem/51759247>
Comment 2 Daniel Bates 2019-06-20 15:45:36 PDT
Created attachment 372595 [details]
Patch
Comment 3 Daniel Bates 2019-06-20 15:49:08 PDT
Comment on attachment 372595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372595&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:210
> +        class_addMethod(self.class, @selector(keyCommands), reinterpret_cast<IMP>(&keyCommandsPlaceHolderHackForEvernote), method_getTypeEncoding(class_getInstanceMethod(self.class, @selector(keyCommands))));

placeholder is one word
Comment 4 Daniel Bates 2019-06-20 15:51:00 PDT
Created attachment 372596 [details]
Patch
Comment 5 Brent Fulgham 2019-06-20 17:03:54 PDT
Comment on attachment 372596 [details]
Patch

So gross, Evernote. Boo!!  r=me
Comment 6 Daniel Bates 2019-06-20 17:49:17 PDT
Comment on attachment 372596 [details]
Patch

Clearing flags on attachment: 372596

Committed r246664: <https://trac.webkit.org/changeset/246664>
Comment 7 Daniel Bates 2019-06-20 17:49:19 PDT
All reviewed patches have been landed.  Closing bug.