Bug 199080 - WebKit context menu highlights include extra padding
Summary: WebKit context menu highlights include extra padding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-20 14:31 PDT by Tim Horton
Modified: 2019-06-21 14:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.15 KB, patch)
2019-06-20 14:31 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (11.64 KB, patch)
2019-06-21 13:50 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-06-20 14:31:13 PDT
WebKit context menu highlights include extra padding
Comment 1 Tim Horton 2019-06-20 14:31:36 PDT
Created attachment 372584 [details]
Patch
Comment 2 Tim Horton 2019-06-20 14:31:38 PDT
<rdar://problem/51140126>
Comment 3 Dean Jackson 2019-06-20 14:47:59 PDT
Comment on attachment 372584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069
> +            request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus;

It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well.

Is this code within HAVE(LINK_PREVIEW)? I know the others are.
Comment 4 Tim Horton 2019-06-20 14:54:18 PDT
Comment on attachment 372584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069
>> +            request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus;
> 
> It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well.
> 
> Is this code within HAVE(LINK_PREVIEW)? I know the others are.

It's not. Perhaps I'll move _shouldUseContextMenus out of HAVE(LINK_PREVIEW) (and make it a property)
Comment 5 Tim Horton 2019-06-21 13:50:11 PDT
Created attachment 372645 [details]
Patch
Comment 6 WebKit Commit Bot 2019-06-21 14:22:57 PDT
Comment on attachment 372645 [details]
Patch

Clearing flags on attachment: 372645

Committed r246697: <https://trac.webkit.org/changeset/246697>
Comment 7 WebKit Commit Bot 2019-06-21 14:22:58 PDT
All reviewed patches have been landed.  Closing bug.