Bug 199080 – WebKit context menu highlights include extra padding

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

WebKit context menu highlights include extra padding

[Tim Horton]

Created attachment 372584 [details]
Patch

[Tim Horton]

<rdar://problem/51140126>

[Dean Jackson]

Comment on attachment 372584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069
> +            request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus;

It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well.

Is this code within HAVE(LINK_PREVIEW)? I know the others are.

[Tim Horton]

Comment on attachment 372584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069
>> +            request.linkIndicatorShouldHaveLegacyMargins = !self._shouldUseContextMenus;
> 
> It doesn't matter but _shouldUseContextMenus is a method. It probably should be actually declared as a property as well.
> 
> Is this code within HAVE(LINK_PREVIEW)? I know the others are.

It's not. Perhaps I'll move _shouldUseContextMenus out of HAVE(LINK_PREVIEW) (and make it a property)

[Tim Horton]

Created attachment 372645 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372645 [details]
Patch

Clearing flags on attachment: 372645

Committed r246697: <https://trac.webkit.org/changeset/246697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.