Bug 199077 - [bmalloc] IsoTLS Layout extension initializes one IsoTLSEntry twice
Summary: [bmalloc] IsoTLS Layout extension initializes one IsoTLSEntry twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-20 13:35 PDT by Yusuke Suzuki
Modified: 2019-06-21 14:32 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2019-06-21 02:03 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2019-06-21 02:12 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2019-06-21 12:36 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-06-20 13:35:53 PDT 
If startEntry == oldLastEntry and IsoTLS is expanded, we construct the same entry twice.
Comment 1 Yusuke Suzuki 2019-06-21 02:03:01 PDT 
Created attachment 372622 [details]
Patch
Comment 2 Yusuke Suzuki 2019-06-21 02:12:40 PDT 
Created attachment 372623 [details]
Patch
Comment 3 EWS Watchlist 2019-06-21 04:10:42 PDT 
Comment on attachment 372623 [details]
Patch

Attachment 372623 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/12540028

New failing tests:
mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl
apiTests
Comment 4 Yusuke Suzuki 2019-06-21 10:20:54 PDT 
(In reply to Build Bot from comment #3)
> Comment on attachment 372623 [details]
> Patch
> 
> Attachment 372623 [details] did not pass jsc-ews (mac):
> Output: https://webkit-queues.webkit.org/results/12540028
> 
> New failing tests:
> mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl
> apiTests

This is flaky test
Comment 5 Yusuke Suzuki 2019-06-21 12:36:57 PDT 
Created attachment 372639 [details]
Patch
Comment 6 Saam Barati 2019-06-21 14:30:05 PDT 
Comment on attachment 372639 [details]
Patch

r=me
Comment 7 Yusuke Suzuki 2019-06-21 14:31:34 PDT 
Committed r246698: <https://trac.webkit.org/changeset/246698>
Comment 8 Radar WebKit Bug Importer 2019-06-21 14:32:17 PDT 
<rdar://problem/52002682>