199073 – [ews-build] Add unit tests for AnalyzeCompileWebKitResults

RESOLVED FIXED199073

[ews-build] Add unit tests for AnalyzeCompileWebKitResults

https://bugs.webkit.org/show_bug.cgi?id=199073

Summary [ews-build] Add unit tests for AnalyzeCompileWebKitResults

Aakash Jain

Reported 2019-06-20 11:16:33 PDT

We should add unit tests for AnalyzeCompileWebKitResults build step in ews-build.

Attachments
Patch (3.27 KB, patch) 2019-06-20 11:18 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-06-20 11:18:56 PDT

Created attachment 372573 [details] Patch

EWS Watchlist

Comment 2 2019-06-20 11:20:45 PDT Comment hidden (obsolete)

Attachment 372573 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2019-06-20 13:24:36 PDT

Comment on attachment 372573 [details] Patch Clearing flags on attachment: 372573 Committed r246650: <https://trac.webkit.org/changeset/246650>

WebKit Commit Bot

Comment 4 2019-06-20 13:24:37 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-06-20 13:27:29 PDT

<rdar://problem/51957288>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Aakash Jain

Reported

2019-06-20 11:16 PDT

Modified

2019-06-20 13:27 PDT History

CC List

6 users Show

URL

Keywords InRadar

Depends on

Blocks