We should add unit tests for AnalyzeCompileWebKitResults build step in ews-build.
Created attachment 372573 [details] Patch
Attachment 372573 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 372573 [details] Patch Clearing flags on attachment: 372573 Committed r246650: <https://trac.webkit.org/changeset/246650>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51957288>