Bug 199066 - [GTK] Stop pretending WebCore::Widget can have a platform widget
Summary: [GTK] Stop pretending WebCore::Widget can have a platform widget
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2019-06-20 04:11 PDT by Carlos Garcia Campos
Modified: 2019-06-20 22:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.02 KB, patch)
2019-06-20 04:13 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-06-20 04:11:18 PDT 
That was only possible in legacy WebKit that we no longer support. The code can be simplified a bit.
Comment 1 Carlos Garcia Campos 2019-06-20 04:13:51 PDT 
Created attachment 372550 [details]
Patch
Comment 2 Michael Catanzaro 2019-06-20 06:56:01 PDT 
Comment on attachment 372550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372550&action=review

Wow, this survived a really long time.

> Source/WebKit/ChangeLog:8
> +        Rename PlatformWidget as PlatformViewWidget to avoid conflict with PlatformWidget defined in WebCore.

Perhaps you hit a unified build issue? WebCore::PlatformWidget and WebKit::PlatformWidget are not the same and should not conflict except when a source file that is using namespace WebCore; gets unified into another source file that isn't expecting it.

Anyway, this change is harmless and I think we can skirt the owner rules if it's a build issue.
Comment 3 Carlos Garcia Campos 2019-06-20 07:44:12 PDT 
Those ifdefs are usually defined outside the namespace, because Namespace::GtkWidget doesn't exist, for example. It has worked so far because we were using GtkWidget in both places.
Comment 4 Carlos Garcia Campos 2019-06-20 22:15:12 PDT 
Committed r246669: <https://trac.webkit.org/changeset/246669>