Bug 199058 - `webkit-patch upload -g` uploaded patches to the wrong bug
Summary: `webkit-patch upload -g` uploaded patches to the wrong bug
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-19 23:03 PDT by Dean Johnson
Modified: 2019-06-19 23:25 PDT (History)
2 users (show)

See Also:


Attachments
Incorrect upload for `webkit upload-patch -g HEAD~2` (4.31 KB, text/plain)
2019-06-19 23:03 PDT, Dean Johnson
no flags Details
Incorrect upload for `webkit upload-patch -g HEAD~1` (28.07 KB, text/plain)
2019-06-19 23:03 PDT, Dean Johnson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Johnson 2019-06-19 23:03:24 PDT
Created attachment 372536 [details]
Incorrect upload for `webkit upload-patch -g HEAD~2`

I had three commits locally I was working on in sequence, and wanted to upload them to separate bugs. I used the commands:

➜  perf.webkit.org git:(summary-page-improvements) webkit-patch upload -g HEAD~2
Total errors found: 0 in 2 files
Was that diff correct? [Y/n]:
Logging in as dean_johnson@apple.com...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Assigning bug 199054 to dean_johnson@apple.com
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=199054

ChangeLog for that commit attached as 'incorrect-upload-HEAD~2.diff`. That should have gone to https://bugs.webkit.org/show_bug.cgi?id=199050.

Next, the same thing happened with HEAD~1:

➜  perf.webkit.org git:(summary-page-improvements) webkit-patch upload -g HEAD~1
Total errors found: 0 in 8 files
Was that diff correct? [Y/n]:
Logging in as dean_johnson@apple.com...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Obsoleting 1 old patch on bug 199054
Obsoleting attachment: 372534
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=199054

ChangeLog for that commit attached as 'incorrect-upload-HEAD~1.diff` That should have gone to https://bugs.webkit.org/show_bug.cgi?id=199051.
Comment 1 Dean Johnson 2019-06-19 23:03:52 PDT
Created attachment 372537 [details]
Incorrect upload for `webkit upload-patch -g HEAD~1`
Comment 2 Dean Johnson 2019-06-19 23:07:58 PDT
Also failing using `webkit-patch upload -g 7df5f9b5a5e730baacf91b9385a321ee3c1b808d` which corresponds to HEAD~2.