Bug 199058 – `webkit-patch upload -g` uploaded patches to the wrong bug

• Status: NEW
• Component: Tools / Tests

[Dean Johnson]

Created attachment 372536 [details]
Incorrect upload for `webkit upload-patch -g HEAD~2`

I had three commits locally I was working on in sequence, and wanted to upload them to separate bugs. I used the commands:

➜  perf.webkit.org git:(summary-page-improvements) webkit-patch upload -g HEAD~2
Total errors found: 0 in 2 files
Was that diff correct? [Y/n]:
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Assigning bug 199054 to [e-mail]
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=199054

ChangeLog for that commit attached as 'incorrect-upload-HEAD~2.diff`. That should have gone to https://bugs.webkit.org/show_bug.cgi?id=199050.

Next, the same thing happened with HEAD~1:

➜  perf.webkit.org git:(summary-page-improvements) webkit-patch upload -g HEAD~1
Total errors found: 0 in 8 files
Was that diff correct? [Y/n]:
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Obsoleting 1 old patch on bug 199054
Obsoleting attachment: 372534
Fetching: https://bugs.webkit.org/show_bug.cgi?id=199054&ctype=xml&excludefield=attachmentdata
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=199054

ChangeLog for that commit attached as 'incorrect-upload-HEAD~1.diff` That should have gone to https://bugs.webkit.org/show_bug.cgi?id=199051.

[Dean Johnson]

Created attachment 372537 [details]
Incorrect upload for `webkit upload-patch -g HEAD~1`

[Dean Johnson]

Also failing using `webkit-patch upload -g 7df5f9b5a5e730baacf91b9385a321ee3c1b808d` which corresponds to HEAD~2.