Bug 199057 – [LFC][IFC] Make the initial strut explicit

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

so that we can ignore it in quirks mode

[Radar WebKit Bug Importer]

<rdar://problem/51927864>

[alan]

Created attachment 372529 [details]
Patch

[Antti Koivisto]

Comment on attachment 372529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372529&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:137
>      auto initialLineConstraints = Line::InitialConstraints {
>          lineInput.horizontalConstraint.logicalTopLeft,
>          lineInput.horizontalConstraint.availableLogicalWidth,
> -        mimimumLineHeight,
> -        initialBaselineOffset
> +        heightConstraints.height,
> +        heightConstraints.baselineOffset,
> +        heightConstraints.strut
>      };

Should InitialConstraints just have HeightConstraints member?

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 372529 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372529&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextLineLayout.cpp:137
> >      auto initialLineConstraints = Line::InitialConstraints {
> >          lineInput.horizontalConstraint.logicalTopLeft,
> >          lineInput.horizontalConstraint.availableLogicalWidth,
> > -        mimimumLineHeight,
> > -        initialBaselineOffset
> > +        heightConstraints.height,
> > +        heightConstraints.baselineOffset,
> > +        heightConstraints.strut
> >      };
> 
> Should InitialConstraints just have HeightConstraints member?
good point!

[alan]

Created attachment 372554 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372554 [details]
Patch

Clearing flags on attachment: 372554

Committed r246634: <https://trac.webkit.org/changeset/246634>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.