Bug 199055 - Remove change that was causing hangs
Summary: Remove change that was causing hangs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-19 20:32 PDT by Megan Gardner
Modified: 2019-06-20 17:50 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.60 KB, patch)
2019-06-19 20:36 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2019-06-19 21:20 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1005.85 KB, application/zip)
2019-06-19 22:41 PDT, EWS Watchlist
no flags Details
Patch (2.41 KB, patch)
2019-06-20 09:54 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2019-06-20 16:36 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-06-19 20:32:29 PDT
Better fix for keyboard buttons
Comment 1 Megan Gardner 2019-06-19 20:36:47 PDT
Created attachment 372524 [details]
Patch
Comment 2 Tim Horton 2019-06-19 20:47:20 PDT
Comment on attachment 372524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372524&action=review

> Source/WebKit/ChangeLog:3
> +        Better fix for keyboard buttons

This is a crazypants title, can it describe the problem instead?

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1070
> +NSString *const UITextInputResponderCapabilitiesChangedSelectionDidChangeKey = @"UITextInputResponderCapabilitiesChangedSelectionDidChangeKey";
> +NSNotificationName const UITextInputResponderCapabilitiesChangedNotification = @"UITextInputResponderCapabilitiesChangedNotification";

It seems unfortunate that we are going in the direction of fragility (what happens when they change the names of these notifications) instead of clarity. Alas

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5777
> +    NSMutableDictionary *userInfo = [NSMutableDictionary dictionaryWithCapacity:2];
> +    userInfo[UITextInputResponderCapabilitiesChangedSelectionDidChangeKey] = @(YES);

Why all this chaos when you could just write @{UITextInputResponderCapabilitiesChangedSelectionDidChangeKey: @YES}?
Comment 3 Megan Gardner 2019-06-19 21:20:19 PDT
Created attachment 372528 [details]
Patch
Comment 4 Tim Horton 2019-06-19 21:26:55 PDT
Comment on attachment 372528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372528&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1071
> +@interface UIWKTextInteractionAssistant (Staging_51927701)

If you really want to do staging don't you needs a respondsToSelector check too?
Comment 5 EWS Watchlist 2019-06-19 22:41:40 PDT
Comment on attachment 372528 [details]
Patch

Attachment 372528 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12527725

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2019-06-19 22:41:42 PDT
Created attachment 372533 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5
Comment 7 Megan Gardner 2019-06-20 09:54:38 PDT
Created attachment 372563 [details]
Patch
Comment 8 Megan Gardner 2019-06-20 16:36:57 PDT
Created attachment 372601 [details]
Patch
Comment 9 Megan Gardner 2019-06-20 16:52:54 PDT
<rdar://problem/51820516>
Comment 10 WebKit Commit Bot 2019-06-20 17:50:13 PDT
Comment on attachment 372601 [details]
Patch

Clearing flags on attachment: 372601

Committed r246665: <https://trac.webkit.org/changeset/246665>
Comment 11 WebKit Commit Bot 2019-06-20 17:50:14 PDT
All reviewed patches have been landed.  Closing bug.