Bug 199055 – Remove change that was causing hangs

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Better fix for keyboard buttons

[Megan Gardner]

Created attachment 372524 [details]
Patch

[Tim Horton]

Comment on attachment 372524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372524&action=review

> Source/WebKit/ChangeLog:3
> +        Better fix for keyboard buttons

This is a crazypants title, can it describe the problem instead?

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1070
> +NSString *const UITextInputResponderCapabilitiesChangedSelectionDidChangeKey = @"UITextInputResponderCapabilitiesChangedSelectionDidChangeKey";
> +NSNotificationName const UITextInputResponderCapabilitiesChangedNotification = @"UITextInputResponderCapabilitiesChangedNotification";

It seems unfortunate that we are going in the direction of fragility (what happens when they change the names of these notifications) instead of clarity. Alas

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5777
> +    NSMutableDictionary *userInfo = [NSMutableDictionary dictionaryWithCapacity:2];
> +    userInfo[UITextInputResponderCapabilitiesChangedSelectionDidChangeKey] = @(YES);

Why all this chaos when you could just write @{UITextInputResponderCapabilitiesChangedSelectionDidChangeKey: @YES}?

[Megan Gardner]

Created attachment 372528 [details]
Patch

[Tim Horton]

Comment on attachment 372528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372528&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1071
> +@interface UIWKTextInteractionAssistant (Staging_51927701)

If you really want to do staging don't you needs a respondsToSelector check too?

[EWS Watchlist]

Comment on attachment 372528 [details]
Patch

Attachment 372528 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12527725

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 372533 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Megan Gardner]

Created attachment 372563 [details]
Patch

[Megan Gardner]

Created attachment 372601 [details]
Patch

[Megan Gardner]

<rdar://problem/51820516>

[WebKit Commit Bot]

Comment on attachment 372601 [details]
Patch

Clearing flags on attachment: 372601

Committed r246665: <https://trac.webkit.org/changeset/246665>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.