RESOLVED FIXED 199047
Web Inspector: current call frame indicator not visible in dark mode
https://bugs.webkit.org/show_bug.cgi?id=199047
Summary Web Inspector: current call frame indicator not visible in dark mode
Matt Baker
Reported 2019-06-19 18:06:29 PDT
Created attachment 372507 [details] [Image] Invisible current call frame indicator This is only a problem when the call stack TreeOutline doesn't have the focus.
Attachments
[Image] Invisible current call frame indicator (599.46 KB, image/png)
2019-06-19 18:06 PDT, Matt Baker
no flags
Patch (2.30 KB, patch)
2019-06-19 18:11 PDT, Matt Baker
no flags
Patch (2.62 KB, patch)
2019-06-20 10:39 PDT, Matt Baker
no flags
Patch (1.94 KB, patch)
2019-07-05 13:59 PDT, Devin Rousso
no flags
[Image] After Patch is applied (141.35 KB, image/png)
2019-07-05 14:05 PDT, Devin Rousso
no flags
Radar WebKit Bug Importer
Comment 1 2019-06-19 18:07:00 PDT
Matt Baker
Comment 2 2019-06-19 18:11:20 PDT
Devin Rousso
Comment 3 2019-06-19 18:19:15 PDT
Comment on attachment 372508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372508&action=review > Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css:58 > + display: none; > +} > + > +.tree-outline .item.call-frame.selected .status > .status-image { > + display: inline-block; Why is this necessary? I'm always cautious of changing `display` because it can have more far reaching implications than most other properties.
Matt Baker
Comment 4 2019-06-20 10:39:15 PDT
Devin Rousso
Comment 5 2019-06-20 11:22:06 PDT
Comment on attachment 372567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372567&action=review r- > Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css:58 > + display: none; This cause the current call frame icon to disappear when changing call frames across an async boundary. # STEPS TO REPRODUCE: 1. inspect <https://webkit.org> 2. set a breakpoint on the first line inside `enableScrollableTables` 3. refresh the page => debugger should pause on the breakpoint set in step 2 4. change call frames to the one before `--- addEvent Listener ---` (should be `Global Code`) => the |> on the `enableScrollableTables` call frame disappears > Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css:107 > + fill: var(--selected-foreground-color); I think this is too bright, especially when compared to the "selected but not focused" background color. We should create a version of `.tree-outline:focus .item.call-frame.selected .status > .status-image` inside a `@media (prefers-color-scheme: dark)`.
Devin Rousso
Comment 6 2019-06-25 10:59:55 PDT
Comment on attachment 372567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372567&action=review > Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css:51 > +.tree-outline .item.call-frame.selected .status > .status-image { This causes the current call frame icon to be warped when a different frame is selected. Same steps to reproduce as below.
Devin Rousso
Comment 7 2019-07-05 13:59:25 PDT
Devin Rousso
Comment 8 2019-07-05 14:05:03 PDT
Created attachment 373535 [details] [Image] After Patch is applied
WebKit Commit Bot
Comment 9 2019-07-05 14:49:01 PDT
Comment on attachment 373532 [details] Patch Clearing flags on attachment: 373532 Committed r247179: <https://trac.webkit.org/changeset/247179>
WebKit Commit Bot
Comment 10 2019-07-05 14:49:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.