Bug 199045 - No menu pop-up when long pressing on a link in Firefox app
Summary: No menu pop-up when long pressing on a link in Firefox app
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-19 17:55 PDT by Dean Jackson
Modified: 2019-06-19 19:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.88 KB, patch)
2019-06-19 17:58 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
Patch (9.97 KB, patch)
2019-06-19 18:02 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (10.74 KB, patch)
2019-06-19 18:45 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-06-19 17:55:07 PDT 
No menu pop-up when long pressing on a link in Firefox app
Comment 1 Dean Jackson 2019-06-19 17:55:42 PDT 
<rdar://problem/51422407>
Comment 2 Dean Jackson 2019-06-19 17:58:40 PDT 
Created attachment 372505 [details]
Patch
Comment 3 Tim Horton 2019-06-19 17:59:55 PDT 
Comment on attachment 372505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372505&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7450
> +    _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer;

IMO [ ] instead of .get() but could go either way
Comment 4 Dean Jackson 2019-06-19 18:02:12 PDT 
Created attachment 372506 [details]
Patch
Comment 5 Dean Jackson 2019-06-19 18:45:45 PDT 
Created attachment 372511 [details]
Patch
Comment 6 Dean Jackson 2019-06-19 19:18:06 PDT 
Committed r246626: <https://trac.webkit.org/changeset/246626>