RESOLVED FIXED 199044
[WASM-References] Add extra tests for Wasm references + fix element parsing and subtyping bugs
https://bugs.webkit.org/show_bug.cgi?id=199044
Summary [WASM-References] Add extra tests for Wasm references + fix element parsing a...
Justin Michaud
Reported 2019-06-19 17:33:42 PDT
Add some extra tests + fix bugs discovered using them
Attachments
Patch (148.74 KB, patch)
2019-06-19 19:01 PDT, Justin Michaud
no flags
Patch (149.14 KB, patch)
2019-06-19 19:31 PDT, Justin Michaud
no flags
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.96 MB, application/zip)
2019-06-19 20:32 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews101 for mac-highsierra (3.18 MB, application/zip)
2019-06-19 20:46 PDT, EWS Watchlist
no flags
Patch (149.13 KB, patch)
2019-06-19 21:15 PDT, Justin Michaud
no flags
Archive of layout-test-results from ews215 for win-future (13.50 MB, application/zip)
2019-06-19 22:41 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews115 for mac-highsierra (3.02 MB, application/zip)
2019-06-19 23:07 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.67 MB, application/zip)
2019-06-19 23:17 PDT, EWS Watchlist
no flags
Patch (150.99 KB, patch)
2019-06-20 10:58 PDT, Justin Michaud
no flags
Justin Michaud
Comment 1 2019-06-19 19:01:28 PDT
Justin Michaud
Comment 2 2019-06-19 19:31:12 PDT
Saam Barati
Comment 3 2019-06-19 20:28:02 PDT
Comment on attachment 372518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372518&action=review r=me > LayoutTests/workers/wasm-references/test.js:1836 > + console.log("Finished test"); is this needed?
EWS Watchlist
Comment 4 2019-06-19 20:32:20 PDT
Comment on attachment 372518 [details] Patch Attachment 372518 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12526769 New failing tests: workers/wasm-hashset.html
EWS Watchlist
Comment 5 2019-06-19 20:32:22 PDT
Created attachment 372523 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 6 2019-06-19 20:46:15 PDT
Comment on attachment 372518 [details] Patch Attachment 372518 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12526860 New failing tests: workers/wasm-hashset.html
EWS Watchlist
Comment 7 2019-06-19 20:46:17 PDT
Created attachment 372525 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Justin Michaud
Comment 8 2019-06-19 21:09:20 PDT
Comment on attachment 372518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372518&action=review >> LayoutTests/workers/wasm-references/test.js:1836 >> + console.log("Finished test"); > > is this needed? I guess if we timeout, it will fail the test, but I put that there so there would be a clear diff between a timeout/failed test and a successful one. wasm-hashset does this too.
Justin Michaud
Comment 9 2019-06-19 21:15:47 PDT
EWS Watchlist
Comment 10 2019-06-19 22:41:18 PDT
Comment on attachment 372527 [details] Patch Attachment 372527 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12527747 New failing tests: workers/wasm-references.html
EWS Watchlist
Comment 11 2019-06-19 22:41:20 PDT
Created attachment 372532 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
EWS Watchlist
Comment 12 2019-06-19 23:07:51 PDT
Comment on attachment 372527 [details] Patch Attachment 372527 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12527756 New failing tests: webgl/2.0.0/conformance/context/context-release-upon-reload.html
EWS Watchlist
Comment 13 2019-06-19 23:07:53 PDT
Created attachment 372538 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 14 2019-06-19 23:17:41 PDT
Comment on attachment 372527 [details] Patch Attachment 372527 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12527769 New failing tests: workers/wasm-references.html
EWS Watchlist
Comment 15 2019-06-19 23:17:43 PDT
Created attachment 372542 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Justin Michaud
Comment 16 2019-06-20 10:58:36 PDT
Justin Michaud
Comment 17 2019-06-20 12:12:00 PDT
Comment on attachment 372570 [details] Patch Windows build failure had no error, and wincairo passed so Alex suggested it is probably just flaky
WebKit Commit Bot
Comment 18 2019-06-20 12:42:54 PDT
Comment on attachment 372570 [details] Patch Clearing flags on attachment: 372570 Committed r246645: <https://trac.webkit.org/changeset/246645>
WebKit Commit Bot
Comment 19 2019-06-20 12:42:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 20 2019-06-20 12:43:22 PDT
Note You need to log in before you can comment on or make changes to this bug.