Add some extra tests + fix bugs discovered using them
Created attachment 372512 [details] Patch
Created attachment 372518 [details] Patch
Comment on attachment 372518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372518&action=review r=me > LayoutTests/workers/wasm-references/test.js:1836 > + console.log("Finished test"); is this needed?
Comment on attachment 372518 [details] Patch Attachment 372518 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12526769 New failing tests: workers/wasm-hashset.html
Created attachment 372523 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 372518 [details] Patch Attachment 372518 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12526860 New failing tests: workers/wasm-hashset.html
Created attachment 372525 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372518&action=review >> LayoutTests/workers/wasm-references/test.js:1836 >> + console.log("Finished test"); > > is this needed? I guess if we timeout, it will fail the test, but I put that there so there would be a clear diff between a timeout/failed test and a successful one. wasm-hashset does this too.
Created attachment 372527 [details] Patch
Comment on attachment 372527 [details] Patch Attachment 372527 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12527747 New failing tests: workers/wasm-references.html
Created attachment 372532 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 372527 [details] Patch Attachment 372527 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12527756 New failing tests: webgl/2.0.0/conformance/context/context-release-upon-reload.html
Created attachment 372538 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372527 [details] Patch Attachment 372527 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12527769 New failing tests: workers/wasm-references.html
Created attachment 372542 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Created attachment 372570 [details] Patch
Comment on attachment 372570 [details] Patch Windows build failure had no error, and wincairo passed so Alex suggested it is probably just flaky
Comment on attachment 372570 [details] Patch Clearing flags on attachment: 372570 Committed r246645: <https://trac.webkit.org/changeset/246645>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51955302>