Bug 199043 - Add unit test for UIContextMenuConfiguration API
Summary: Add unit test for UIContextMenuConfiguration API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-19 17:26 PDT by Alex Christensen
Modified: 2019-06-20 15:30 PDT (History)
7 users (show)

See Also:


Attachments
Patch (29.37 KB, patch)
2019-06-19 17:33 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (29.41 KB, patch)
2019-06-19 19:24 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (29.46 KB, patch)
2019-06-19 22:19 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (29.45 KB, patch)
2019-06-20 09:55 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (29.56 KB, patch)
2019-06-20 09:56 PDT, Alex Christensen
wenson_hsieh: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (13.51 MB, application/zip)
2019-06-20 13:42 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-06-19 17:26:42 PDT
Add unit test for UIContextMenuConfiguration API
Comment 1 Alex Christensen 2019-06-19 17:33:28 PDT
Created attachment 372502 [details]
Patch
Comment 2 Alex Christensen 2019-06-19 19:24:20 PDT
Created attachment 372516 [details]
Patch
Comment 3 Alex Christensen 2019-06-19 22:19:22 PDT
Created attachment 372531 [details]
Patch
Comment 4 Alex Christensen 2019-06-20 09:55:30 PDT
Created attachment 372564 [details]
Patch
Comment 5 Alex Christensen 2019-06-20 09:56:49 PDT
Created attachment 372565 [details]
Patch
Comment 6 Build Bot 2019-06-20 13:42:50 PDT
Comment on attachment 372565 [details]
Patch

Attachment 372565 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12533588

New failing tests:
storage/indexeddb/modern/get-keyrange.html
Comment 7 Build Bot 2019-06-20 13:42:54 PDT
Created attachment 372580 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 8 Wenson Hsieh 2019-06-20 14:01:14 PDT
Comment on attachment 372565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372565&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1196
> +@property (nonatomic, weak) id<_UIClickInteractionDriverDelegate> delegate;

Nit - I think we usually put a space between id and < for ObjC protocols.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:799
> +- (id<_UIClickInteractionDriving>)_clickInteractionDriverForTesting

Nit - space here too.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:89
> +@property (nonatomic, setter=_setClickInteractionDriverForTesting:) id<_UIClickInteractionDriving> _clickInteractionDriverForTesting WK_API_AVAILABLE(ios(WK_IOS_TBA));

Nit - space here too.

> Tools/TestWebKitAPI/ios/UIKitSPI.h:207
> +    

Nit - extra newline
Comment 9 Alex Christensen 2019-06-20 15:29:03 PDT
http://trac.webkit.org/r246657
Comment 10 Radar WebKit Bug Importer 2019-06-20 15:30:25 PDT
<rdar://problem/51962989>