Bug 199033 – Web Inspector: Debugger: setting a breakpoint on a non-JavaScript line should immediately show as unresolved

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. set a breakpoint on a non-<script> line of any HTML file
 => breakpoint icon shows blue
3. move (drag) the breakpoint to a different non-script line in the same file
 => breakpoint icon changes to dark grey

[Devin Rousso]

Created attachment 372497 [details]
Patch

[Matt Baker]

Comment on attachment 372497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372497&action=review

r=me, nice change.

> Source/WebInspectorUI/ChangeLog:12
> +        by the time that `shouldSpeculativelyResolve` would've taken effect, so it's unnecessary.

Any idea why it existed in the first place?

> Source/WebInspectorUI/ChangeLog:14
> +        This only affects resolving breakpoints set via the gutter of a `SourceCodeTextEditor`.

Maybe "This parameter was only used when setting a breakpoint via...". I had to check the code to clarify.

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:933
> +    _setBreakpoint(breakpoint, specificTarget)

Interesting. It looks like a breakpoint only begins its life in the resolved state when restoring breakpoints in DebuggerManager.prototype.initializeTarget (specificTarget will be non-null).

[Radar WebKit Bug Importer]

<rdar://problem/51957111>

[Devin Rousso]

Comment on attachment 372497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372497&action=review

>> Source/WebInspectorUI/ChangeLog:12
>> +        by the time that `shouldSpeculativelyResolve` would've taken effect, so it's unnecessary.
> 
> Any idea why it existed in the first place?

It was added in r171784.  My guess is that at the time, `breakpoint.resolved` was used as a "gate" for invoking certain backend commands, so automatically marking it as resolved would help avoid those.  Nowadays, it's not used for basically anything other than UI.

[Devin Rousso]

Created attachment 372592 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372592 [details]
Patch

Clearing flags on attachment: 372592

Committed r246659: <https://trac.webkit.org/changeset/246659>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.