199031 – [ews-build] Patch link should open the pretty patch

Bug 199031 - [ews-build] Patch link should open the pretty patch

Summary: [ews-build] Patch link should open the pretty patch

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Aakash Jain

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2019-06-19 13:46 PDT by Aakash Jain
Modified:	2019-06-19 15:48 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (1.19 KB, patch) 2019-06-19 13:48 PDT, Aakash Jain	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Aakash Jain 2019-06-19 13:46:56 PDT

EWS builds have a link to patch, however it opens the plain text version of the patch which isn't much readable. It would be better to link to prettypatch which is more readable (and shows the diff in color).

Comment 1 Aakash Jain 2019-06-19 13:48:09 PDT

Created attachment 372491 [details]
Patch

Comment 2 Aakash Jain 2019-06-19 13:49:25 PDT

The difference is:

https://bugs.webkit.org/attachment.cgi?id=372491
vs
https://bugs.webkit.org/attachment.cgi?id=372491&action=prettypatch

Comment 3 WebKit Commit Bot 2019-06-19 15:45:58 PDT

Comment on attachment 372491 [details]
Patch

Clearing flags on attachment: 372491

Committed r246613: <https://trac.webkit.org/changeset/246613>

Comment 4 WebKit Commit Bot 2019-06-19 15:45:59 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-06-19 15:48:44 PDT

<rdar://problem/51917356>