WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199031
[ews-build] Patch link should open the pretty patch
https://bugs.webkit.org/show_bug.cgi?id=199031
Summary
[ews-build] Patch link should open the pretty patch
Aakash Jain
Reported
2019-06-19 13:46:56 PDT
EWS builds have a link to patch, however it opens the plain text version of the patch which isn't much readable. It would be better to link to prettypatch which is more readable (and shows the diff in color).
Attachments
Patch
(1.19 KB, patch)
2019-06-19 13:48 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-06-19 13:48:09 PDT
Created
attachment 372491
[details]
Patch
Aakash Jain
Comment 2
2019-06-19 13:49:25 PDT
The difference is:
https://bugs.webkit.org/attachment.cgi?id=372491
vs
https://bugs.webkit.org/attachment.cgi?id=372491&action=prettypatch
WebKit Commit Bot
Comment 3
2019-06-19 15:45:58 PDT
Comment on
attachment 372491
[details]
Patch Clearing flags on attachment: 372491 Committed
r246613
: <
https://trac.webkit.org/changeset/246613
>
WebKit Commit Bot
Comment 4
2019-06-19 15:45:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2019-06-19 15:48:44 PDT
<
rdar://problem/51917356
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug