Bug 199022 - Web Inspector: Dark Mode: inactive tab bar item should get darker on hover
Summary: Web Inspector: Dark Mode: inactive tab bar item should get darker on hover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-19 12:12 PDT by Devin Rousso
Modified: 2019-06-20 17:55 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.28 KB, patch)
2019-06-19 13:11 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (492.08 KB, image/png)
2019-06-19 13:11 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-19 12:12:54 PDT
.
Comment 1 Matt Baker 2019-06-19 12:15:43 PDT
I suspect this regressed when the uncovered inactive tab color was made darker. IMO, it is too dark now.
Comment 2 Devin Rousso 2019-06-19 12:18:46 PDT
Will address in <https://webkit.org/b/199023>.

*** This bug has been marked as a duplicate of bug 199023 ***
Comment 3 Devin Rousso 2019-06-19 12:23:43 PDT
As it turns out, <https://webkit.org/b/199023> was just my mouse moving too quickly and triggering some hover styling.
Comment 4 Devin Rousso 2019-06-19 13:11:23 PDT
Created attachment 372488 [details]
Patch
Comment 5 Devin Rousso 2019-06-19 13:11:41 PDT
Created attachment 372489 [details]
[Image] After Patch is applied
Comment 6 WebKit Commit Bot 2019-06-20 17:54:16 PDT
Comment on attachment 372488 [details]
Patch

Clearing flags on attachment: 372488

Committed r246666: <https://trac.webkit.org/changeset/246666>
Comment 7 WebKit Commit Bot 2019-06-20 17:54:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-20 17:55:17 PDT
<rdar://problem/51968584>