Bug 19902 - [XBL] We need to check nodes for content errors
Summary: [XBL] We need to check nodes for content errors
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-05 01:35 PDT by Julien Chaffraix
Modified: 2011-01-22 10:27 PST (History)
2 users (show)

See Also:


Attachments
Add a boolean flag and per tag check (10.71 KB, patch)
2008-07-05 01:40 PDT, Julien Chaffraix
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2008-07-05 01:35:38 PDT
Nodes in errors (because of its parent) should be marked while parsing. This will enable us to ignore them later when doing some processing (as requested by the specification).
Comment 1 Julien Chaffraix 2008-07-05 01:40:54 PDT
Created attachment 22096 [details]
Add a boolean flag and per tag check
Comment 2 Eric Seidel (no email) 2008-07-06 18:04:51 PDT
Comment on attachment 22096 [details]
Add a boolean flag and per tag check

I'm not sure addChild is the correct place to check.  childrenChanged on XBLElement is probably a better place.

Either way, error checking and propagation isn't a required to get simple things up and running.  I suggest you ask hyatt where the correct place to put this type of checking is... or we just deal with it later when we're further along.
Comment 3 Dimitri Glazkov (Google) 2011-01-22 10:27:25 PST
We ripped this code out and a new implementation is under way.