WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 202421
199016
[WinCairo] Allow RemoteInspector socket protocol to exchange backendCommands.
https://bugs.webkit.org/show_bug.cgi?id=199016
Summary
[WinCairo] Allow RemoteInspector socket protocol to exchange backendCommands.
Basuke Suzuki
Reported
2019-06-19 10:49:08 PDT
This process was omitted in WinCairo's socket implementation.
Attachments
Add attachment
proposed patch, testcase, etc.
Basuke Suzuki
Comment 1
2019-06-19 12:25:06 PDT
1. Attach hash of embedded backendCommands.js to backend when sending `SetupInspectorClient` event.
https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/Source/WebKit/UIProcess/glib/RemoteInspectorClient.cpp#L209
2. Backend checks received hash with its own backendCommands.js. If they are different, send the content to frontend. If they are same, send empty string.
https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp#L277
Note: The result of 2 is returned via DBus's feature. Our implementation needs to create a new event for that. 3. Client get the backendCommands result and pass it to remote inspector proxy.
https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/Source/WebKit/UIProcess/glib/RemoteInspectorClient.cpp#L237
Note: This must be the first message for client to process. It can be possible `SetTargetList` event is delivered before it. We need to sync this situation.
Basuke Suzuki
Comment 2
2019-10-01 13:11:36 PDT
*** This bug has been marked as a duplicate of
bug 202421
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug