Bug 199015 - Web Inspector: REGRESSION: Debugger: current call frame indicator isn't vertically centered
Summary: Web Inspector: REGRESSION: Debugger: current call frame indicator isn't verti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-19 10:23 PDT by Devin Rousso
Modified: 2019-06-19 18:48 PDT (History)
5 users (show)

See Also:


Attachments
[Image] Screenshot of Issue (36.34 KB, image/png)
2019-06-19 10:23 PDT, Devin Rousso
no flags Details
Patch (1.33 KB, patch)
2019-06-19 10:25 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-19 10:23:50 PDT
Created attachment 372473 [details]
[Image] Screenshot of Issue

.
Comment 1 Devin Rousso 2019-06-19 10:25:27 PDT
Created attachment 372474 [details]
Patch
Comment 2 Matt Baker 2019-06-19 17:36:59 PDT
Comment on attachment 372474 [details]
Patch

r=me, how does this look on non-retina?
Comment 3 Devin Rousso 2019-06-19 18:17:37 PDT
Comment on attachment 372474 [details]
Patch

(In reply to Matt Baker from comment #2)
> Comment on attachment 372474 [details]
> Patch
> 
> r=me, how does this look on non-retina?
I tried it in a bunch of different resolutions, and I think it looks better in all of them.
Comment 4 WebKit Commit Bot 2019-06-19 18:47:28 PDT
Comment on attachment 372474 [details]
Patch

Clearing flags on attachment: 372474

Committed r246624: <https://trac.webkit.org/changeset/246624>
Comment 5 WebKit Commit Bot 2019-06-19 18:47:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-06-19 18:48:17 PDT
<rdar://problem/51924197>