Bug 198988 - [WHLSL] The checker needs to resolve types for the anonymous variables in ReadModifyWrite expressions
Summary: [WHLSL] The checker needs to resolve types for the anonymous variables in Rea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-18 18:38 PDT by Saam Barati
Modified: 2019-06-19 19:06 PDT (History)
9 users (show)

See Also:


Attachments
patch (10.25 KB, patch)
2019-06-19 17:11 PDT, Saam Barati
dino: review+
Details | Formatted Diff | Diff
patch for landing (10.28 KB, patch)
2019-06-19 18:23 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-06-18 18:38:48 PDT
float4 x;
x[1] += 20;
Comment 1 Saam Barati 2019-06-19 11:55:50 PDT
Seems like it’s actually name resolution for types
Comment 2 Saam Barati 2019-06-19 16:44:52 PDT
patch forthcoming
Comment 3 Saam Barati 2019-06-19 17:11:26 PDT
Created attachment 372501 [details]
patch
Comment 4 Build Bot 2019-06-19 17:14:09 PDT
Attachment 372501 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dean Jackson 2019-06-19 17:24:26 PDT
Comment on attachment 372501 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372501&action=review

> Source/WebCore/ChangeLog:11
> +        		

TAB!!!!!!! Security has been called.
Comment 6 Saam Barati 2019-06-19 17:48:02 PDT
(In reply to Dean Jackson from comment #5)
> Comment on attachment 372501 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372501&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        		
> 
> TAB!!!!!!! Security has been called.

Vim likes to insert tabs when it auto indents changelog entries. It's super annoying.

Thanks for the review.
Comment 7 Myles C. Maxfield 2019-06-19 17:49:26 PDT
r=me
Comment 8 Saam Barati 2019-06-19 18:23:18 PDT
Created attachment 372510 [details]
patch for landing
Comment 9 WebKit Commit Bot 2019-06-19 19:05:34 PDT
Comment on attachment 372510 [details]
patch for landing

Clearing flags on attachment: 372510

Committed r246625: <https://trac.webkit.org/changeset/246625>
Comment 10 WebKit Commit Bot 2019-06-19 19:05:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-06-19 19:06:17 PDT
<rdar://problem/51924745>