Bug 198988 – [WHLSL] The checker needs to resolve types for the anonymous variables in ReadModifyWrite expressions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Saam Barati]

float4 x;
x[1] += 20;

[Saam Barati]

Seems like it’s actually name resolution for types

[Saam Barati]

patch forthcoming

[Saam Barati]

Created attachment 372501 [details]
patch

[EWS Watchlist]

Attachment 372501 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 372501 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372501&action=review

> Source/WebCore/ChangeLog:11
> +        		

TAB!!!!!!! Security has been called.

[Saam Barati]

(In reply to Dean Jackson from comment #5)
> Comment on attachment 372501 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=372501&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        		
> 
> TAB!!!!!!! Security has been called.

Vim likes to insert tabs when it auto indents changelog entries. It's super annoying.

Thanks for the review.

[Myles C. Maxfield]

r=me

[Saam Barati]

Created attachment 372510 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 372510 [details]
patch for landing

Clearing flags on attachment: 372510

Committed r246625: <https://trac.webkit.org/changeset/246625>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51924745>